Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support published assets on Laravel Vapor #524

Merged
merged 1 commit into from Jan 14, 2020

Conversation

@harrygulliford
Copy link
Contributor

harrygulliford commented Jan 14, 2020

1️⃣ Is this something that is wanted/needed? Did you create a feature-request issue first?

Sure is - #385 and #385 (comment)

2️⃣ Does it contain multiple, unrelated changes? Please separate the PRs out.

I would never!

3️⃣ Does it include tests if possible? (Not a deal-breaker, just a nice-to-have)

The dog ate my homework tests. However, I did manually test it on Vapor - works like a charm with zero-config.

4️⃣ Please include a thorough description of the feature/fix and reasons why it's useful.

Currently, published Livewire assets cannot be used on Vapor because the app url and asset url are not the same (assets are hosted on a CDN). This PR sets the correct published asset path for apps hosted on Vapor by auto-detecting the environment.

Screen Shot 2020-01-14 at 5 14 26 pm

5️⃣ Thanks for contributing! 🙌

And thank you for hosting some comedy podcast that sometimes talks about programming and "tea drinking" 👀

@calebporzio calebporzio merged commit 066d96a into livewire:master Jan 14, 2020
24 checks passed
24 checks passed
PHP:7.2 / Laravel:5.6.*(prefer-lowest)
Details
PHP:7.2 / Laravel:5.6.*(prefer-stable)
Details
PHP:7.2 / Laravel:5.7.*(prefer-lowest)
Details
PHP:7.2 / Laravel:5.7.*(prefer-stable)
Details
PHP:7.2 / Laravel:5.8.*(prefer-lowest)
Details
PHP:7.2 / Laravel:5.8.*(prefer-stable)
Details
PHP:7.2 / Laravel:6.*(prefer-lowest)
Details
PHP:7.2 / Laravel:6.*(prefer-stable)
Details
PHP:7.3 / Laravel:5.6.*(prefer-lowest)
Details
PHP:7.3 / Laravel:5.6.*(prefer-stable)
Details
PHP:7.3 / Laravel:5.7.*(prefer-lowest)
Details
PHP:7.3 / Laravel:5.7.*(prefer-stable)
Details
PHP:7.3 / Laravel:5.8.*(prefer-lowest)
Details
PHP:7.3 / Laravel:5.8.*(prefer-stable)
Details
PHP:7.3 / Laravel:6.*(prefer-lowest)
Details
PHP:7.3 / Laravel:6.*(prefer-stable)
Details
PHP:7.4 / Laravel:5.6.*(prefer-lowest)
Details
PHP:7.4 / Laravel:5.6.*(prefer-stable)
Details
PHP:7.4 / Laravel:5.7.*(prefer-lowest)
Details
PHP:7.4 / Laravel:5.7.*(prefer-stable)
Details
PHP:7.4 / Laravel:5.8.*(prefer-lowest)
Details
PHP:7.4 / Laravel:5.8.*(prefer-stable)
Details
PHP:7.4 / Laravel:6.*(prefer-lowest)
Details
PHP:7.4 / Laravel:6.*(prefer-stable)
Details
@harrygulliford harrygulliford deleted the harrygulliford:vapor-asset-url branch Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.