Added ability to bind to address other than 127.0.0.1, have server send 220 instead of 200 as the first request and attempted to make shutdown cleaner using non-blocking accepts. #5

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@bparker98

Let me know if there are any issues I need to correct. Sorry I'm such a git noob.

Added :BindAddress to @options to set the IP Address to bind the server to. Added :ExternalAddress to @options to be able to test PASV support with a firewall. Added :Use220First to @options to have the server return a 220 response instead of a 200 response upon connection to fix compatibility with some FTP clients. Fixed an issue with the PORT command that prevented Active connections from working properly. Changed socket.accept in start() to be non-blocking so the server can be shut down cleaner.

Added :BindAddress to @options to set the IP Address to bind the serv…
…er to. Added :ExternalAddress to @options to be able to test PASV support with a firewall. Added :Use220First to @options to have the server return a 220 response instead of a 200 response upon connection to fix compatibility with some FTP clients. Fixed an issue with the PORT command that prevented Active connections from working properly. Changed socket.accept in start() to be non-blocking so the server can be shut down cleaner.
@sax

This comment has been minimized.

Show comment Hide comment
@sax

sax Jul 29, 2011

Member

I'll take a look when I get a chance. If other clients respond well to 220 I may change the default behavior, but I'll need to play with a few clients to see how well that's supported.

Also, I'll take a look at your updates to the binding code.

Member

sax commented Jul 29, 2011

I'll take a look when I get a chance. If other clients respond well to 220 I may change the default behavior, but I'll need to play with a few clients to see how well that's supported.

Also, I'll take a look at your updates to the binding code.

@meatballhat

This comment has been minimized.

Show comment Hide comment
@meatballhat

meatballhat Jul 26, 2017

Member

@bparker98 Please holler if you're interested in reworking + reopening this PR ❤️

Member

meatballhat commented Jul 26, 2017

@bparker98 Please holler if you're interested in reworking + reopening this PR ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment