Switch branches/tags
Nothing to show
Commits on Jun 7, 2012
  1. merged from facebook repo

    davesims committed Jun 7, 2012
Commits on May 30, 2012
  1. git ignore updates

    davesims committed May 30, 2012
  2. merging in latest version

    davesims committed May 30, 2012
Commits on Apr 17, 2012
  1. Merge small pull requests

    rightparen committed Apr 16, 2012
    To give credit for changes, I am listing author/pull request here
    for changes incorporated in this checkin.
    I am submitting these changes directly to master to preserve a
    linear history, to allow for minor edits, and to credit multiple
    people when more than one change was merged to fix a single issue.
    === Summary by submitter of pull requests in this commit ===
    - 160: ClassCastExceptions in
    grant land:
    - 216: Fix ArrayOutOfBoundsException when clicking "Don't Allow" in FbDialog one
    - 117: Fixed a NPE
    - 261: Add support for Android build system.
    - 218: Fix exception when trying to decode invalid string
    - 246: Fix for Issue #160: ClassCastExceptions filling up the logs.
    To investigate pull request 260, I enabled orientation changes in Hackbook.
    This did not demonstrate the issue, but doesn't hurt anything and makes it
    easier to test on the x86 emulator.
    I also fixed some build issues in Hackbook around SDK version required and
    the path to the SDK.
    Test Plan:
    Full clean builds of facebook and Hackbook.
    Verify creating Eclipse project per public docs still works.
    Upload photo in Android Hackbook.
    Reviewers: caabernathy, jacl, vijaye, yariv
    Reviewed By: jacl
    CC: ekoneil, gregschechte
    Differential Revision:
    Revert Plan: Safe to revert
    Task ID: 1028564
Commits on Mar 21, 2012
  1. Fixed null pointer issue.

    rightparen committed Mar 21, 2012
    We need to call unbindService on a Context.  In some cases, mAuthActivity
    is null.  Since applicationsContext is passed in to the constructor
    and never modified, it should not be null.  So we call unbindService
    on applicationsContext instead.
    Test Plan: Try SSO with pre-1.8 FB app.
    Reviewers: vijaye, jacl, caabernathy
    Reviewed By: vijaye
    CC: selekman, constantin, lshepard
    Differential Revision:
    Revert Plan: Safe to revert
    Task ID: 982981
Commits on Feb 17, 2012
  1. Disable logging by default

    vijaye committed Feb 17, 2012
    Logging was turned on unconditionally before, which led to apps leaking
    sensitive data.  This change puts the logging api behind an explicit gate that
    developers have to turn on.
    It's unfortunate that this isn't automatic - ideally this would automatically
    turn on for non-release signed bits.  I couldn't find such a check in Android
    framework.  If android experts have better ways of tackling this, i'm all ears.
    But bear in mind this is a security fix and needs to go out asap.
    Test Plan: Launched in default mode and verified no logging in emulator.
    Turned on log gate and verified logging.
    Reviewers: mmarucheck, lshepard, yariv, raghuc1
    Reviewed By: mmarucheck
    CC: gregschechte, jacl
    Differential Revision:
    Task ID: 933141
  2. Fixing Token refresh issue in SDK

    vijaye committed Feb 17, 2012
    The TokenRefresh intent is exposed as a service, but we were validating it as
    an activity.  Fixign that and refactoring code. This code should have never
    Note that without the FB app the refresh token feature will not work.  If that
    is necessary, it's not part of this diff.
    Test Plan: Verify that hackbook can login & refresh token on the emulator.
    Reviewers: mmarucheck, yariv, ttung, raghuc1, trvish, pfung
    Reviewed By: mmarucheck
    CC: gregschechte, jacl, lshepard
    Differential Revision:
    Task ID: 926377
Commits on Jan 18, 2012
Commits on Dec 30, 2011
  1. Added the refresh token method.

    Kamil Kraszewski committed with Kamil Kraszewski Dec 1, 2011
    Summary: This allows developers to silently refresh their access token by
    calling Facebook.refreshToken method. This SDK will try to call our Facebook
    Android App which will handle the API call.
    Test Plan:
    This requires adding a refresh token service to our sdk. See D364973.
    After that try using the new Hackbook example.
    Reviewers: jimbru, raghuc1, brent, dalves, ttung, yariv
    Reviewed By: jimbru
    CC: dalves, jimbru
    Differential Revision:
    Task ID: 799996
Commits on Dec 20, 2011
  1. Update

    dpurdy committed Dec 20, 2011
  2. Update

    dpurdy committed Dec 20, 2011
  3. updated build targets to match deals_android

    Dan Mayer committed Dec 20, 2011
Commits on Dec 19, 2011
  1. fixes issues on newer android oses when FB redirects across domains c…

    Dan Mayer committed Dec 19, 2011
    …ause ssl exception
Commits on Dec 1, 2011
  1. Fixed setAccessExpiresIn method.

    Kamil Kraszewski committed with Kamil Kraszewski Dec 1, 2011
    There are two types of access tokens:
     - ones that doesn't expire (expiresIn == 0)
     - ones that have some expiration period( (expiresIn > 0)
    When we receive a new token from FB server for both them we call the
    setAccessExpiresIn method.
    Because of that:
    1. We shouldn't ignore the "0" value
    2. We should also expect tokens that have long expiration period.
    For example 60 days is 2592000000000 miliseconds which is too much for an
    integer variable to handle :)
    Test Plan: Tried Login In / Logout for both types of tokens.
    Reviewers: jimbru, yariv
    Reviewed By: jimbru
    CC: kamil, jimbru
    Differential Revision: 370353
  2. Refactoring of Android's Hackbook example

    Kamil Kraszewski committed with Kamil Kraszewski Nov 30, 2011
    Cleaning of the Hackbook code. Main reason of this commit is mixing tabs and
    white spaces inside the code, which makes the code ugly (for example browsing
    the code inside github).
    In addition I also refactored few other things:
     - I tried to wrap the lines to 100 characters per line (80 per comments) - at
    least in those places where it made sense
     - Remove trailing whitespaces and unnecessary blank lines
     - Add missing @Override adnnotations
     - Fixed syntax in some places (like "for(i=0;..." -> "for (i = 0;...")
     - Added missing 'static' keywords
    Test Plan:
    Run the app and see if everything works :-)
    Reviewers: jimbru, raghuc1, vksgupta, dalves
    Reviewed By: dalves
    CC: platform-diffs@lists, nbushak, dalves
    Differential Revision: 370079
Commits on Oct 26, 2011
  1. use ~/

    davesims committed Oct 26, 2011
Commits on Oct 10, 2011
  1. [android][oauth2] add more descriptive description to invalid_key errors

    Ray He committed Oct 10, 2011
    This is the android sdk side of D340841.
    The hope is that developers will be able to take the key they passed
    in and past it into their application, thus skipping the necessity of
    having keytool and openssl. It also reduces frustration.
    Test Plan:
    This requires a change to our sdk :-/, which currently dosn't show error
    descriptions. Anyone
    know how I can push a change to the git repo?
    We start with non-useful error message. After applying this and the sdk change,
    we get the
    after pasting in our key from the message, sso succeeds
    Reviewers: yariv, jimbru, ahimel, brent, lshepard
    Reviewed By: jimbru
    CC: platform-diffs@lists, ptarjan, naitik, rhe, jimbru, yariv, lshepard
    Differential Revision: 341355
    Revert Plan: ok
    Platform Impact (PUBLIC):
    Android SSO invalid_key failures will now contain the key that
    developers attempted to use.  If this key were to be copied directly
    into the application settings, SSO will work properly for this
    application. This makes it so that developers never have to mess
    around with keytool/openssl. They can just attempt a request with a
    dummy string, then use the error string returned by our endpoint.
  2. Hackbook for Android Sample app.

    Vikas Gupta committed Sep 15, 2011
    Summary: The sample app includes SSO, feed and apprequests dialogs, get friends
    via graph or fql, post on friend's wall, get nearby places and check-in to a
    place, upload photo from local media gallery or remote server and Graph API
    Test Plan: The sample app can be downloaded from: Try it out and lmk if
    code can be optimized or other changes.
    Reviewers: lshepard, mattwkelly, dkim, dlim, caabernathy, omids
    Reviewed By: dkim
    CC: platform-diffs@lists, nbushak, vksgupta, ccwu, erling, dlim, dkim
    Differential Revision: 325685
Commits on Oct 7, 2011
  1. Remove the title for dialogs and add the 'x' on the top left corner

    Vikas Gupta committed Sep 26, 2011
    Summary: For the oauth, feed, request dialogs, removed the title bar and added
    the 'x' button on the top left corner which when pressed dismisses the dialog.
    Test Plan: Launched Hackbook and click on Login or requests, feed dialogs and
    confirm that there is no title bar and the cross button is rightly displayed and
    dismisses the dialog.
    Reviewers: lshepard, yariv, jimbru, dkim, ttung, omids, raghuc1
    Reviewed By: ttung
    CC: caabernathy, brent, vksgupta, mattwkelly, lshepard, ttung
    Differential Revision: 333017
    Task ID: 700698
Commits on Aug 31, 2011
  1. Merge branch 'feature/cancel-dialog'

    Dan Mayer committed Aug 31, 2011
  2. Merge branch 'extra-try-catch-checking'

    Dan Mayer committed Aug 31, 2011
  3. Merge branch 'feature/decodeUrl-bug'

    Dan Mayer committed Aug 31, 2011
  4. change android target

    Dan Mayer committed Aug 31, 2011
Commits on Aug 30, 2011
  1. Adding some try/catch blocks around these calls

    nikreiman committed Aug 30, 2011
    If the user hits the "back" button on their device at the right time (or rather, the wrong time), then this can cause the FBDialog class to throw some strange exceptions about not being attached to the current activity, etc. Better to just put in a bit of extra protection here and swallow any exceptions that may result.
Commits on Aug 19, 2011
  1. Fix exception when trying to decode invalid string

    nikreiman committed Aug 19, 2011
    This exception is barely seen in regular development, but if there is some problem with your corresponding Facebook App then Facebook will return URL fragments with a reference like "_", which caused this method to throw an uncaught ArrayIndexOutOfBoundsException. Since this method is splitting to key/values anyways, this little safety check will prevent the app from crashing.
Commits on Mar 17, 2011
  1. Fix dialog sizing on devices with small (QVGA) screens.

    jimbru committed Mar 8, 2011
    This fixes dialog sizing on devices with small screens. In particular,
    the bottom buttons will now be visible and no longer hang off the screen.
Commits on Feb 2, 2011
Commits on Jan 18, 2011
  1. Add support for a 'state' parameter on async requests.

    Jim Brusstar committed Jan 18, 2011
    This change allows developers to attach an arbitrary object to an asynchronous
    Facebook request that will be returned in the request's callback, which
    should make it easier to distinguish the returns from concurrent requests.
Commits on Dec 22, 2010
  1. Updating Facebook for Android apk to v1.5.0.

    Jim Brusstar committed Dec 22, 2010
Commits on Dec 13, 2010