New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolved issue where compiling via CLI would be stuck in a while loop… #184

Merged
merged 2 commits into from Nov 5, 2015

Conversation

Projects
None yet
3 participants
@curtjen

curtjen commented Oct 19, 2015

Resolved issue where compiling via CLI would be stuck in a while loop if no GemFile or .git directory exists.

Curtis Jensen - BH
Resolved issue where compiling via CLI would be stuck in a while loop…
… if not GemFile or .git directory exists.
@@ -85,6 +85,10 @@ def find_root_path
break
end
path = File.expand_path('..', path)
if path === '/'
puts 'No GemFile or .git found. Compiling anyway.'

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2015

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Do not write to stdout. Use Rails' logger if you want to log.

@@ -85,6 +85,10 @@ def find_root_path
break
end
path = File.expand_path('..', path)
if path === '/'

This comment has been minimized.

@houndci-bot

houndci-bot Oct 19, 2015

Avoid the use of the case equality operator ===.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@hagenburger

This comment has been minimized.

Member

hagenburger commented Oct 19, 2015

Thanks! I’ll have a look.

Did you already try out version 2? It’s currently released as alpha version. The final version is pretty close to be released. This behavior change a bit in version 2.

@curtjen

This comment has been minimized.

curtjen commented Oct 19, 2015

I haven't taken a look at version 2, yet. I'll start tinkering with it. Thanks!

hagenburger added a commit that referenced this pull request Nov 5, 2015

Merge pull request #184 from curtjen/bug-fix/compile-issues-for-non-g…
…emfile-and-git-users

Resolved issue where compiling via CLI would be stuck in a while loop…

@hagenburger hagenburger merged commit 40c4951 into livingstyleguide:master Nov 5, 2015

1 check passed

hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment