Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUpdate for rails-sprockets 3 #188
Conversation
houndci-bot
reviewed
Feb 1, 2016
| @@ -3,7 +3,9 @@ | ||
| require 'rails' | ||
| class LivingStyleGuideRailtie < Rails::Railtie | ||
| initializer 'living_style_guide.assets' do | ||
| Rails.application.assets.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate) | ||
| Rails.application.config.assets.configure do |env| | ||
| env.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate) |
This comment has been minimized.
This comment has been minimized.
houndci-bot
Feb 1, 2016
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
hagenburger
added
the
refactoring/optimization
label
Feb 1, 2016
This comment has been minimized.
This comment has been minimized.
|
Thanks for your pull request, @cjmarkham! Does this still work with Rails 3? If you find the time, it would be nice if you could squash this into one commit. |
This comment has been minimized.
This comment has been minimized.
|
I haven't been able to test on rails 3 but I can confirm it works on rails sprockets versions 2 and 3 |
This comment has been minimized.
This comment has been minimized.
dpehrson
commented
Feb 9, 2016
|
Would it be easier if this pull request was reopened into v2 since it does not support rails 3? Would love to see this fixed so I don't have to install from my fork. |
This comment has been minimized.
This comment has been minimized.
|
I’ll have a look asap and will check it for v1 and v2. |
hagenburger
referenced this pull request
Feb 16, 2016
Closed
Sass::SyntaxError: File to import not found or unreadable: livingstyleguide #189
added a commit
that referenced
this pull request
Feb 18, 2016
hagenburger
merged commit b219353
into
livingstyleguide:master
Feb 18, 2016
1 of 2 checks passed
This comment has been minimized.
This comment has been minimized.
|
So finally Travis CI is working and I could release it. Thank you! I’m also going to put this in v2. |
cjmarkham commentedFeb 1, 2016
There have been changes to the way engines are registered in
rails-sprockets 3. This PR updates the initializer to the version 3 method.rails/sprockets-rails#292