Update for rails-sprockets 3 #188
Merged
Conversation
| @@ -3,7 +3,9 @@ | |||
| require 'rails' | |||
| class LivingStyleGuideRailtie < Rails::Railtie | |||
| initializer 'living_style_guide.assets' do | |||
| Rails.application.assets.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate) | |||
| Rails.application.config.assets.configure do |env| | |||
| env.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate) | |||
houndci-bot
Feb 1, 2016
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
Thanks for your pull request, @cjmarkham! Does this still work with Rails 3? If you find the time, it would be nice if you could squash this into one commit. |
|
I haven't been able to test on rails 3 but I can confirm it works on rails sprockets versions 2 and 3 |
|
Would it be easier if this pull request was reopened into v2 since it does not support rails 3? Would love to see this fixed so I don't have to install from my fork. |
|
I’ll have a look asap and will check it for v1 and v2. |
hagenburger
added a commit
that referenced
this pull request
Feb 18, 2016
update for rails-sprockets 3
hagenburger
merged commit b219353
into
livingstyleguide:master
1 of 2 checks passed
1 of 2 checks passed
hound
1 violation found.
|
So finally Travis CI is working and I could release it. Thank you! I’m also going to put this in v2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
There have been changes to the way engines are registered in
rails-sprockets 3. This PR updates the initializer to the version 3 method.rails/sprockets-rails#292