New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for rails-sprockets 3 #188

Merged
merged 1 commit into from Feb 18, 2016

Conversation

Projects
None yet
4 participants
@cjmarkham
Contributor

cjmarkham commented Feb 1, 2016

There have been changes to the way engines are registered in rails-sprockets 3. This PR updates the initializer to the version 3 method.

rails/sprockets-rails#292

@@ -3,7 +3,9 @@
require 'rails'
class LivingStyleGuideRailtie < Rails::Railtie
initializer 'living_style_guide.assets' do
Rails.application.assets.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate)
Rails.application.config.assets.configure do |env|
env.register_engine('.lsg', ::LivingStyleGuide::TiltTemplate)

This comment has been minimized.

@houndci-bot

houndci-bot Feb 1, 2016

Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@hagenburger

This comment has been minimized.

Member

hagenburger commented Feb 1, 2016

Thanks for your pull request, @cjmarkham! Does this still work with Rails 3?

If you find the time, it would be nice if you could squash this into one commit.

@cjmarkham

This comment has been minimized.

Contributor

cjmarkham commented Feb 2, 2016

I haven't been able to test on rails 3 but I can confirm it works on rails sprockets versions 2 and 3

@dpehrson

This comment has been minimized.

dpehrson commented Feb 9, 2016

Would it be easier if this pull request was reopened into v2 since it does not support rails 3? Would love to see this fixed so I don't have to install from my fork.

@hagenburger

This comment has been minimized.

Member

hagenburger commented Feb 10, 2016

I’ll have a look asap and will check it for v1 and v2.

hagenburger added a commit that referenced this pull request Feb 18, 2016

Merge pull request #188 from givey/master
update for rails-sprockets 3

@hagenburger hagenburger merged commit b219353 into livingstyleguide:master Feb 18, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
hound 1 violation found.
@hagenburger

This comment has been minimized.

Member

hagenburger commented Feb 18, 2016

So finally Travis CI is working and I could release it. Thank you!
https://rubygems.org/gems/livingstyleguide/versions/1.4.0

I’m also going to put this in v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment