Invalid line spacing for last line with button

[ivanvorobei]

Attached example:

Code for init:

let text = AttributedString(NSAttributedString(string: text), .font(textFont), .color(descriptionLabel.textColor))
        let button = AttributedString(NSAttributedString(string: button), .font(buttonFont), .color(buttonColor), .action([.color(buttonColor.withAlphaComponent(0.5))], action))
        descriptionLabel.attributed.text = text + " " + button

Code for layout

titleLabel.frame.origin = .zero
titleLabel.frame.set(width: frame.width)
titleLabel.sizeToFit()
        
descriptionLabel.frame = CGRect.init(x: 0, y: titleLabel.frame.bottomY + 4, width: frame.width, height: 0)
descriptionLabel.sizeToFit()

Number of lines set to zero.

[lixiang1994]

I found that when there are two different font sizes in a row, it will look like in the screenshot.

This is a problem of NSAttributedString, but I know how to achieve the desired effect.

Can be solved by setting the line height:

label.attributed.text = .init(text + " " + button, .paragraph(.maximumLineHeight(30), .minimumLineHeight(30)))

e.g.

[lixiang1994]

The root cause is the difference between line spacing and line height.

[ivanvorobei]

I try set -2, and it no do anything for me. If positive - doing

[lixiang1994]

Is the line height invalid?

[ivanvorobei]

I set only maximum & minimum, no do any additional. It need?

[lixiang1994]

let text = AttributedString(string: text, .font(textFont), .color(descriptionLabel.textColor))
        let button = AttributedString(string: button, .font(buttonFont), .color(buttonColor), .action([.color(buttonColor.withAlphaComponent(0.5))], action))
descriptionLabel.attributed.text = .init(text + " " + button, .paragraph(.maximumLineHeight(30), .minimumLineHeight(30)))

After running this code, what is the result?

[ivanvorobei]

With 30 spacing more. But I try set -2 or even zero. Result this:

Last line with button have bigger space

[lixiang1994]

God, can you extract more complete code for me, I need to debug and analyze.

[lixiang1994]

Before that, I need to confirm whether the system font is used?

[ivanvorobei]

Sorry, I simple use your code as you send.
This that I use

let textFont = UIFont.preferredFont(forTextStyle: .footnote)
let buttonFont = UIFont.preferredFont(forTextStyle: .footnote, weight: .medium)
        
let textAttributed = AttributedString(NSAttributedString(string: text + text), .font(textFont), .foreground(descriptionLabel.textColor))
let buttonAttributed = AttributedString(NSAttributedString(string: button), .font(buttonFont), .foreground(buttonColor), .action([.foreground(buttonColor.withAlphaComponent(0.5))], action))
descriptionLabel.attributed.text = .init(textAttributed + " " + buttonAttributed, .paragraph(.maximumLineHeight(-2), .minimumLineHeight(-2)))

[lixiang1994]

UIFont.preferredFont(forTextStyle: .footnote, weight: .medium) ??? Is it an extension?

[lixiang1994]

my code:

[lixiang1994]

Line height must be greater than 0 to take effect

[ivanvorobei]

@lixiang1994 you full right. I set zero and it not work. When I set textFont.lineHeight it start work
Thanks for your time and big help!

[lixiang1994]

Line spacing and line height are different.

[lixiang1994]

My pleasure

[ivanvorobei]

Sorry, catch strange behaviour.

Code

let textFont = UIFont.preferredFont(forTextStyle: .footnote)
let buttonFont = UIFont.preferredFont(forTextStyle: .footnote, weight: .medium).rounded()
let buttonColor = SPInterface.tintColor
        
let text = "you full right. I set zero and it not work. When I set textFont.lineHeight it start work. Thanks for your time and big help!"
let button = "Action"
let textAttributed = AttributedString(NSAttributedString(string: text), .font(textFont), .foreground(descriptionLabel.textColor))
        let buttonAttributed = AttributedString(NSAttributedString(string: button), .font(buttonFont), .foreground(buttonColor), .action([.foreground(buttonColor.withAlphaComponent(0.5))], {
            print("call")
        }))
descriptionLabel.numberOfLines = 0
descriptionLabel.attributed.text = .init(textAttributed + " " + buttonAttributed, .paragraph(.maximumLineHeight(textFont.lineHeight), .minimumLineHeight(textFont.lineHeight)))
        
scrollView.addSubview(descriptionLabel)
descriptionLabel.frame = CGRect.init(x: 20, y: 20, width: 200, height: 0)
descriptionLabel.sizeToFit()

It basic code, only with line height.
But if text small (you can set one work and button and text in 1 line) - all work, if many lines (like example which I attach), button not clickable

[lixiang1994]

Try it.

scrollView.delaysContentTouches = fasle

[ivanvorobei]

descriptionLabel placed not on scroll view

[lixiang1994]

???

[ivanvorobei]

Yes, in example. I try remove it and place to view. Similar bug

[lixiang1994]

My code

Can you check the touch response?
For example Parent view isUserInteractionEnabled

[ivanvorobei]

Even adding to empty project, also not work. I did example, you can check?
attributed-not-call.zip

[lixiang1994]

Thanks.
I have fixed it. 🎉
Because I use font leading, but some fonts are incomplete.
Please update to version 1.5.2.

[ivanvorobei]

It work now!
Thanks!