Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: `Image` not defined on node #6

Merged
merged 7 commits into from Nov 17, 2019
Merged

Conversation

@JounQin
Copy link
Contributor

JounQin commented Nov 3, 2019

JounQin added 2 commits Nov 3, 2019
@liximomo

This comment has been minimized.

Copy link
Owner

liximomo commented Nov 3, 2019

Any user case for extra ignore rules? An example repo will be appreciated.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 3, 2019

@liximomo In Angular app, it requires plain string html and style contents.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 3, 2019

@liximomo If you don't mind, you can checkout https://github.com/rx-ts/pkgr/blob/master/packages/webpack/package.json#L43 and change it to published latest version @0.1.10 and then run yarn && yarn dev:angular at project root dir.

It's a bit big repo, sorry for it.

lib/plugin.js Outdated Show resolved Hide resolved
JounQin added 2 commits Nov 4, 2019
README.md Outdated Show resolved Hide resolved
@liximomo liximomo self-requested a review Nov 4, 2019
Copy link
Owner

liximomo left a comment

Type should be Function[] | RegExp[].

Match webpack entry request to be ignored from lazy compiler > Request to be ignored from lazy compiler.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 4, 2019

Type should be Function[] | RegExp[].

Match webpack entry request to be ignored from lazy compiler > Request to be ignored from lazy compiler.

Done.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 5, 2019

@liximomo Any other idea or can we just merge and release this?

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 6, 2019

@liximomo I also found every lazy loading module from loadChildren of Angular Router was considered as an entry module because it refreshed every time for first loading.

Sorry, ignore it temporarily, I need debug it first and figure out where is the main issue.

@JounQin

This comment has been minimized.

Copy link
Contributor Author

JounQin commented Nov 10, 2019

@liximomo Any news??

@liximomo liximomo merged commit 2c36247 into liximomo:master Nov 17, 2019
@liximomo

This comment has been minimized.

Copy link
Owner

liximomo commented Nov 17, 2019

@JounQin Thanks for your contribution.

@JounQin JounQin deleted the JounQin:patch-1 branch Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.