Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in load_embedding function #3

Closed
lixinsu opened this issue Apr 1, 2019 · 0 comments
Closed

Bug in load_embedding function #3

lixinsu opened this issue Apr 1, 2019 · 0 comments
Assignees
@Albert-Ma
Labels
bug Something isn't working

Comments

@lixinsu
Copy link
Owner

lixinsu commented Apr 1, 2019 •
edited
Loading

The word_dict is not passed to the function and limit max text length
@lixinsu lixinsu added the bug Something isn't working label Apr 1, 2019
@Albert-Ma Albert-Ma self-assigned this Apr 1, 2019
@lixinsu lixinsu removed the bug Something isn't working label Apr 1, 2019
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix word_dict bug #3
05eb19e
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
restrict max seq len for dataloader #3
0127191
@lixinsu lixinsu added the bug Something isn't working label Apr 1, 2019
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
change variable embedding to word_embedding and modify `Attention…
39fee54 
…` function param #3
@Albert-Ma Albert-Ma mentioned this issue Apr 1, 2019
Merged
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix bugs #3
9766ec2
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix bugs #3
c8a5713
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix bugs #3
20460f5
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix bugs #3
850df8d
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
move useless param #3
f99da4f
Albert-Ma pushed a commit that referenced this issue Apr 1, 2019
fix bug #3
55655ab
lixinsu pushed a commit that referenced this issue Apr 1, 2019
@Albert-Ma @lixinsu
Hotfix/word dict (#13)
2b26411 
* fix `word_dict` bug #3

* restrict max seq len for dataloader #3

* change variable `embedding` to `word_embedding` and modify `Attention` function param #3

* fix bugs #3

* fix bugs #3

* fix bugs #3

* fix bugs #3

* move useless param #3

* fix bug #3

* Fix bug

* add gen esim config

* add esim config momentarily, a better config management is needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Albert-Ma Albert-Ma

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Albert-Ma @lixinsu