Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/unify_mask #36

Closed
Albert-Ma opened this issue Jul 15, 2019 · 0 comments
Closed

Feature/unify_mask #36

Albert-Ma opened this issue Jul 15, 2019 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@Albert-Ma
Copy link
Collaborator

Now, esim and bmipm model use 1 mask value, but bert use 0 mask value.
Unify the mask mechanism which use 0 mask value, this is also consistent with tf.

@Albert-Ma Albert-Ma self-assigned this Jul 15, 2019
@Albert-Ma Albert-Ma added the enhancement New feature or request label Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant