Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(es5): Add tests for `symbol` types #45

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@ExE-Boss
Copy link
Contributor

commented Oct 7, 2019

This has been pointed out in DefinitelyTyped/DefinitelyTyped#38947 (comment).

@ljharb

This comment has been minimized.

Copy link
Owner

commented Oct 7, 2019

@ExE-Boss i'm somehow unable to force push to the PR branch on your fork despite "allow edits" being checked. Do you perhaps have branch protection set up, or created your fork in some atypical way?

@ExE-Boss

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Well, the fork is created on an organisation account (@EB-Forks) and not a personal account (@ExE-Boss).

@ljharb

This comment has been minimized.

Copy link
Owner

commented Oct 7, 2019

Hmm, I'd still expect if you have admin access on https://github.com/EB-Forks/ES-ToPrimitive that collabs on this PR would be given push access to it. Perhaps it's a github bug.

@ljharb

This comment has been minimized.

Copy link
Owner

commented Oct 7, 2019

Are you an org owner, or do you have explicit write/admin access on that repo?

@ExE-Boss

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

I’m the owner of the @EB-Forks (and @EB-Tech) organisations.


I’ve added you as a collaborator to the forked repository, so you should be able to push to it now.

@ljharb ljharb force-pushed the EB-Forks:test/es5/symbols branch from 39d881e to 8a03544 Oct 8, 2019
@ljharb
ljharb approved these changes Oct 8, 2019
@ljharb ljharb force-pushed the EB-Forks:test/es5/symbols branch from 8a03544 to 78b5eab Oct 8, 2019
@ljharb ljharb merged commit 78b5eab into ljharb:master Oct 8, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@ljharb ljharb deleted the EB-Forks:test/es5/symbols branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.