Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for proving window.location works with Object.assign polyfill #68

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@JakeChampion
Copy link

JakeChampion commented Mar 6, 2019

No description provided.

@ljharb

ljharb approved these changes Mar 7, 2019

Copy link
Owner

ljharb left a comment

Thanks! Verified passing in IE 11.

@ljharb ljharb force-pushed the JakeChampion:patch-1 branch from 13f8428 to 0ba0252 Mar 7, 2019

@JakeChampion

This comment has been minimized.

Copy link
Author

JakeChampion commented Mar 7, 2019

It looks to fail the linting because the linter believes window to be undefined.

Should we disable the no-undef rule on each line that use window or should we add window to the globals that are allowed in the file?

@ljharb

This comment has been minimized.

Copy link
Owner

ljharb commented Mar 8, 2019

I think an eslint override comment adding it as a global in the test function should work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.