Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrayFormat: 'comma' not producing suggested results #299

Closed
rustlemills opened this Issue Feb 18, 2019 · 3 comments

Comments

Projects
None yet
4 participants
@rustlemills
Copy link

rustlemills commented Feb 18, 2019

Testing the example code in the README.md

qs.stringify({ a: ['b', 'c'] }, { arrayFormat: 'comma' })

Actual behavior

The output was 'a[0]=b&a[1]=c'
(Or more specifically 'a%5B0%5D=b&a%5B1%5D=c')

Expected behavior

I was expecting 'a=b,c'

Code to reproduce

qs.stringify({ a: ['b', 'c'] }, { arrayFormat: 'comma' })
@kpainter

This comment has been minimized.

Copy link

kpainter commented Feb 19, 2019

I'm also experiencing this issue. It appears that the feature is present in the Github repository but has not been published to the NPM registry.

When installing the latest package from NPM it doesn't include any of this functionality.

@ljharb

This comment has been minimized.

Copy link
Owner

ljharb commented Feb 19, 2019

Yes, that's correct. As you can see here: b84acba the functionality has not yet been released.

@ljharb ljharb closed this Feb 19, 2019

@zantic

This comment has been minimized.

Copy link

zantic commented Mar 12, 2019

Any idea about when it will be?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.