Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFixed `Qs` -> `qs` in browser #297
Conversation
niftylettuce
referenced this pull request
Feb 4, 2019
Open
Standalone export should be "qs" not "Qs"? #298
ljharb
added
the
semver-major: breaking change
label
Feb 4, 2019
ljharb
closed this
Feb 4, 2019
niftylettuce
deleted the
niftylettuce:patch-1
branch
Feb 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
niftylettuce commentedFeb 4, 2019
The library does not export a default constructor, so we should not export to
windowa variableQs, it should beqsinstead, and thus will match the Node API.