Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] comma option enabled value parsing to use strings only #334

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@Om4ar
Copy link
Contributor

commented Oct 4, 2019

in case of comma enabled .. parsing should check for strings only when using indexOf(',')

fixes: #328

dist/qs.js Outdated Show resolved Hide resolved
lib/parse.js Show resolved Hide resolved
@ljharb ljharb added the parse label Oct 4, 2019
main.js Outdated Show resolved Hide resolved
ljharb added a commit to Om4ar/qs that referenced this pull request Oct 4, 2019
Fixes ljharb#334.
@ljharb ljharb force-pushed the Om4ar:comma-parse-indexof branch from 68c9541 to 982681a Oct 4, 2019
@ljharb

This comment has been minimized.

Copy link
Owner

commented Oct 4, 2019

The test you added passes without your fix - can you tweak the test so it fails without the fix?

@Om4ar Om4ar requested a review from ljharb Oct 4, 2019
@ljharb ljharb force-pushed the Om4ar:comma-parse-indexof branch from fc51485 to 698b683 Oct 4, 2019
@ljharb
ljharb approved these changes Oct 4, 2019
Copy link
Owner

left a comment

Thanks!

@Om4ar

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

@ljharb thank you
i learned a lot from this

@ljharb ljharb merged commit 698b683 into ljharb:master Oct 4, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.