New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguments entered with quotes are not parsed correctly #7

Closed
ljvillanueva opened this Issue Jun 1, 2016 · 1 comment

Comments

Projects
None yet
1 participant
@ljvillanueva
Owner

ljvillanueva commented Jun 1, 2016

Checking on some weird behavior a user reported, noticed that entering an argument with quotes rendered it as invalid. The function ended up using the default value. Need to try casting the value as a number to avoid this problem or stop execution and report the problem instead of running the function without letting the user know that the argument was not being used.

> acoustic_complexity(s1, j = 8, max_freq=2000, fft_w = 80) 

 This is a mono file.

 Calculating index. Please wait... 

  Acoustic Complexity Index (total): 53.48468

> acoustic_complexity(s1, j = 8, max_freq="2000", fft_w = 80) 

 WARNING: The maximum acoustic frequency that this file can use is 10000Hz. But the script was set to measure up to 2000Hz. The value of max_freq was changed to 10000.


 This is a mono file.

 Calculating index. Please wait... 

  Acoustic Complexity Index (total): 287.1439

@ljvillanueva ljvillanueva added the bug label Jun 1, 2016

@ljvillanueva ljvillanueva self-assigned this Jun 1, 2016

@ljvillanueva

This comment has been minimized.

Show comment
Hide comment
@ljvillanueva

ljvillanueva Jul 21, 2016

Owner

Fixed in v 1.3.2.

Owner

ljvillanueva commented Jul 21, 2016

Fixed in v 1.3.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment