New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Second, third and fourth level domains #466

Open
sobolevn opened this Issue Jun 16, 2018 · 12 comments

Comments

Projects
None yet
3 participants
@sobolevn
Collaborator

sobolevn commented Jun 16, 2018

We can possible enhance internet provider to be able to generate fake domains like:

  • test.wemake.services
  • mail.google.com
  • app.test.example.com
  • example.co.uk
    And others.

Link: https://en.wikipedia.org/wiki/Domain_name#Second-level_and_lower_level_domains

@lk-geimfari lk-geimfari added this to the Hacktoberfest 2018! milestone Sep 27, 2018

@lk-geimfari lk-geimfari removed their assignment Oct 13, 2018

@sadielbartholomew

This comment has been minimized.

Contributor

sadielbartholomew commented Oct 15, 2018

Hi, can I have a go at this if nobody else is working on it already?

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Oct 16, 2018

@sadielbartholomew Hi! Sure! It would be awesome!

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Oct 16, 2018

@sadielbartholomew Friendly note: This feature can be implemented in the provider Internet().

@sadielbartholomew

This comment has been minimized.

Contributor

sadielbartholomew commented Oct 16, 2018

Perfect, thanks @lk-geimfari. I will attempt issue 484 first, but if nobody else has started to work on this by then I will try it.

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Oct 16, 2018

@sadielbartholomew Great! Thank you!

@sadielbartholomew

This comment has been minimized.

Contributor

sadielbartholomew commented Oct 27, 2018

I've now had time to start implementing this; I'm working on it in this branch. Once it is complete, tested & documented I will put in a PR. Thanks again.

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Oct 27, 2018

@sadielbartholomew Great news! Thank you for your time and for your interest! We'll wait for your PR.

@lk-geimfari lk-geimfari removed this from the Hacktoberfest 2018! milestone Nov 4, 2018

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Nov 7, 2018

@sadielbartholomew

This comment has been minimized.

Contributor

sadielbartholomew commented Nov 7, 2018

Sorry @lk-geimfari I am a bit busy at the moment but will get back onto this at the weekend. If I can't otherwise sort it I will post here so somebody else can take over (or do it their way).

@lk-geimfari

This comment has been minimized.

Owner

lk-geimfari commented Nov 8, 2018

@sadielbartholomew Sure! Thanks!

@sadielbartholomew

This comment has been minimized.

Contributor

sadielbartholomew commented Nov 12, 2018

Update: I am committed to completing this, but I am short for time so it will likely be mid-week before I can put in the corresponding PR. I will ensure I get it submitted before next Monday, however. Thanks for your patience.

@sobolevn

This comment has been minimized.

Collaborator

sobolevn commented Nov 12, 2018

@sadielbartholomew no pressure! Take your time. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment