Add vectrino #126
Merged
Add vectrino #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 12 commits
January 15, 2024 17:15
plan for add_vectrino branch
add Nortek Vectrino as a supported instrument
changes to read Nortek Vectrino ADV
add vno_data dict
include check for Nortek/vectrino in _set_coords
include test for Nortek Vectrino (vectrino_data01)
include vectrino_data01.vno in list of tests
include Nortek Vectrino (.vno) files as git lfs tracked files
add vectrino_data01.vno file as example data
add vecrino_data01.nc for testing
add support for Nortek Vectrino (.vno) files
todo list completed
Pull Request Test Coverage Report for Build 7538996910
💛 - Coveralls |
|
@rfonsecadasilva Thank you for adding this! Looks great. @lkilcher Want to review and merge? |
lkilcher
approved these changes
Mar 6, 2024
jmcvey3
pushed a commit
to jmcvey3/dolfyn
that referenced
this pull request
Mar 7, 2024
* Create todo_add_vectrino.md plan for add_vectrino branch * Update about.rst add Nortek Vectrino as a supported instrument * Update nortek.py changes to read Nortek Vectrino ADV * Update nortek_defs.py add vno_data dict * Update base.py include check for Nortek/vectrino in _set_coords * Update test_read_adv.py include test for Nortek Vectrino (vectrino_data01) * Update api.py include vectrino_data01.vno in list of tests * Update .gitattributes include Nortek Vectrino (.vno) files as git lfs tracked files * Create vectrino_data01.vno add vectrino_data01.vno file as example data * Create vectrino_data01.nc add vecrino_data01.nc for testing * Update changelog.md add support for Nortek Vectrino (.vno) files * Delete todo_add_vectrino.md todo list completed --------- Co-authored-by: Renan Silva <00099335@uwa.edu.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Nortek Vectrino (.vno) files.