[Feature Request]Make folders configurable #32

Closed
atomfrede opened this Issue Sep 12, 2016 · 14 comments

Comments

Projects
None yet
3 participants
@atomfrede
Contributor

atomfrede commented Sep 12, 2016

It would be cool to make folders configurable (like in the official maven plugin):

  <configFolder>${project.basedir}/src/test/resources</configFolder>
  <dataFolder>${project.basedir}/src/test/resources/data</dataFolder>
  <resultsFolder>${project.basedir}/target/gatling/results</resultsFolder>
  <bodiesFolder>${project.basedir}/src/test/resources/bodies</bodiesFolder>
  <simulationsFolder>${project.basedir}/src/test/scala</simulationsFolder>

I can see the advantage of a sane convention, but at least an option to configure paths would be very cool (I am considering this plugin to be included in jhipster generator instead of our own custom solution)

@atomfrede atomfrede changed the title from Make the base path configurable to [Feature Request]Make folders configurable Sep 12, 2016

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Nov 14, 2016

Contributor

If there is interest in this feature I could try to prepare a merge request

Contributor

atomfrede commented Nov 14, 2016

If there is interest in this feature I could try to prepare a merge request

@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Nov 14, 2016

Collaborator

+1 for PR :)

Collaborator

eshepelyuk commented Nov 14, 2016

+1 for PR :)

@atomfrede atomfrede referenced this issue in jhipster/generator-jhipster Aug 18, 2017

Closed

Epic: Enhance Gradle Support #6252

atomfrede added a commit to atomfrede/gradle-gatling-plugin that referenced this issue Aug 31, 2017

* Update gatling tooling
* Make folders configurable if no autodetection is desired

update #32

lkishalmi added a commit that referenced this issue Sep 6, 2017

Configurable source folders (#42)
* * Update gatling tooling
* Make folders configurable if no autodetection is desired

update #32

* * source root can be configured
* gatling folders are configurable
* default is now gatling 2.3.0 and scala 2.12.3
* both can be configured

* remove commons lang

* update readme

* update readme with new properties

* revert wrapper

* revert wrapper

* revert wrapper

* fix logback config
@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Sep 6, 2017

Collaborator

@atomfrede @lkishalmi Have you noticed that build is failing after merging #42
for example here https://travis-ci.org/lkishalmi/gradle-gatling-plugin/builds/272337457

Collaborator

eshepelyuk commented Sep 6, 2017

@atomfrede @lkishalmi Have you noticed that build is failing after merging #42
for example here https://travis-ci.org/lkishalmi/gradle-gatling-plugin/builds/272337457

@lkishalmi

This comment has been minimized.

Show comment
Hide comment
@lkishalmi

lkishalmi Sep 6, 2017

Owner
Owner

lkishalmi commented Sep 6, 2017

@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Sep 6, 2017

Collaborator

@lkishalmi I could help on weekends,
@atomfrede maybe you can take a look too ?

Collaborator

eshepelyuk commented Sep 6, 2017

@lkishalmi I could help on weekends,
@atomfrede maybe you can take a look too ?

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Sep 6, 2017

Contributor

@eshepelyuk @lkishalmi I just executed gradle check locally and it works fine, can somebody restart the travis build? The build for the PR was also green, looks like a travis error somehow.

Contributor

atomfrede commented Sep 6, 2017

@eshepelyuk @lkishalmi I just executed gradle check locally and it works fine, can somebody restart the travis build? The build for the PR was also green, looks like a travis error somehow.

@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Sep 6, 2017

Collaborator

Does gradle check includes gradle test ? Are you using Gradle wrapper for running the tests locally, because TravisCI used wrapper.

Collaborator

eshepelyuk commented Sep 6, 2017

Does gradle check includes gradle test ? Are you using Gradle wrapper for running the tests locally, because TravisCI used wrapper.

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Sep 6, 2017

Contributor

Yes gradle Check executes all tests. That's also what Travis is doing. Using the wrapper yes.

Contributor

atomfrede commented Sep 6, 2017

Yes gradle Check executes all tests. That's also what Travis is doing. Using the wrapper yes.

@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Sep 6, 2017

Collaborator

@atomfrede - the same from my side. all works locally

Collaborator

eshepelyuk commented Sep 6, 2017

@atomfrede - the same from my side. all works locally

@lkishalmi

This comment has been minimized.

Show comment
Hide comment
@lkishalmi

lkishalmi Sep 7, 2017

Owner

All is working for me locally as well.

Owner

lkishalmi commented Sep 7, 2017

All is working for me locally as well.

@eshepelyuk

This comment has been minimized.

Show comment
Hide comment
@eshepelyuk

eshepelyuk Sep 8, 2017

Collaborator

Good news, build is green now. Are you going to create a new release for this feature ?

Collaborator

eshepelyuk commented Sep 8, 2017

Good news, build is green now. Are you going to create a new release for this feature ?

@lkishalmi

This comment has been minimized.

Show comment
Hide comment
@lkishalmi

lkishalmi Sep 8, 2017

Owner

Yes. Soon.

Owner

lkishalmi commented Sep 8, 2017

Yes. Soon.

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Sep 10, 2017

Contributor

👍 I will add your plugin to https://github.com/jhipster/generator-jhipster so you may see a raise in downloads and issues/questions. I also talked with @oehme about how to handle the deprecation warning when using gradle 4 (currently the plugin assumes one source folder. That api will be removed in gradle 5). Will try to provide a PR for that after the new release.

Contributor

atomfrede commented Sep 10, 2017

👍 I will add your plugin to https://github.com/jhipster/generator-jhipster so you may see a raise in downloads and issues/questions. I also talked with @oehme about how to handle the deprecation warning when using gradle 4 (currently the plugin assumes one source folder. That api will be removed in gradle 5). Will try to provide a PR for that after the new release.

@atomfrede

This comment has been minimized.

Show comment
Hide comment
@atomfrede

atomfrede Sep 10, 2017

Contributor

Release is available, so let's close this.

EDIT: I guess it takes some time until it is "really" available. Gradle plugin portal already shows 0.5.0 but neither the jar nor the pom are available to download. CC @lkishalmi

Contributor

atomfrede commented Sep 10, 2017

Release is available, so let's close this.

EDIT: I guess it takes some time until it is "really" available. Gradle plugin portal already shows 0.5.0 but neither the jar nor the pom are available to download. CC @lkishalmi

@atomfrede atomfrede closed this Sep 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment