fix(plugins): handle nil intermediate values in JSON path traversal #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfleader
force-pushed
the
fix-jsonpointer-usage
branch
from
9ef2a27 to
e5ac5dd
Compare
mfleader
force-pushed
the
fix-jsonpointer-usage
branch
from
e5ac5dd to
1142c63
Compare
Uses go-openapi/jsonpointer@v0.21.2 fix to improve handling of intermediate nil values. Signed-off-by: Matthew F Leader <mleader@redhat.com>
mfleader
force-pushed
the
fix-jsonpointer-usage
branch
from
1142c63 to
03ac1ad
Compare
rhdedgar
approved these changes
Aug 11, 2025
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Aug 19, 2025
…lamastack#136) Simplify field mutator implementation by leveraging jsonpointer v0.21.2 fix for nil intermediate values during field mutation. Replaces complex manual traversal with direct jsonpointer calls and streamlined path creation logic. Improved error handling through jsonpointer's improved error messages. Previously worked around: panic: reflect: call of reflect.Value.Type on zero Value. Approved-by: rhdedgar (cherry picked from commit b11bd68)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…lamastack#136) Simplify field mutator implementation by leveraging jsonpointer v0.21.2 fix for nil intermediate values during field mutation. Replaces complex manual traversal with direct jsonpointer calls and streamlined path creation logic. Improved error handling through jsonpointer's improved error messages. Previously worked around: panic: reflect: call of reflect.Value.Type on zero Value. Approved-by: rhdedgar (cherry picked from commit b11bd68)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify field mutator implementation by leveraging jsonpointer v0.21.2 fix for nil intermediate values during field mutation. Replaces complex manual traversal with direct jsonpointer calls and streamlined path creation logic. Improved error handling through jsonpointer's improved error messages.
Previously worked around: panic: reflect: call of reflect.Value.Type on zero Value.