Update base image for initContainers #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VaishnaviHire
requested review from
cdoern,
derekhiggins,
leseb,
mfleader,
nathan-weinberg,
rhdedgar and
rhuss
as code owners
VaishnaviHire
requested review from
leseb
and removed request for
cdoern,
derekhiggins,
leseb,
mfleader,
nathan-weinberg and
rhuss
derekhiggins
reviewed
Sep 9, 2025
| YQ_VERSION ?= v4.45.3 | ||
| YAMLFMT_VERSION ?= v0.12.0 | ||
| CRD_REF_DOCS_VERSION = v0.1.0 | ||
| CRD_REF_DOCS_VERSION = v0.2.0 |
There was a problem hiding this comment.
nit: This seem unrelated is it required?
There was a problem hiding this comment.
I do see this error in my local env
Downloading github.com/elastic/crd-ref-docs@v0.1.0
golang.org/x/tools/internal/tokeninternal
# golang.org/x/tools/internal/tokeninternal
../../go/pkg/mod/golang.org/x/tools@v0.19.0/internal/tokeninternal/tokeninternal.go:64:9: invalid array length -delta * delta (constant -256 of type int64)
There was a problem hiding this comment.
Are we going to cherry-pick this? If so I'd like to have at least two separate commits. Thanks!
There was a problem hiding this comment.
Yep, updated to separate commits
derekhiggins
approved these changes
Sep 9, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Signed-off-by: Vaishnavi Hire <vhire@redhat.com>
Update the elastic/crd-ref-docs to v0.2.0 Signed-off-by: Vaishnavi Hire <vhire@redhat.com>
VaishnaviHire
force-pushed
the
update_init
branch
from
562b29b to
732c692
Compare
rhdedgar
approved these changes
Sep 9, 2025
|
@leseb Is this good to merge? |
leseb
approved these changes
Sep 11, 2025
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Oct 6, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Oct 6, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80) (cherry picked from commit 09c595a)
VaishnaviHire
added a commit
to opendatahub-io/llama-stack-k8s-operator
that referenced
this pull request
Oct 6, 2025
[sync] Update base image for initContainers (llamastack#159)
VaishnaviHire
added a commit
to red-hat-data-services/llama-stack-k8s-operator
that referenced
this pull request
Oct 6, 2025
Update base image for initContainers (llamastack#159)
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Oct 15, 2025
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments Approved-by: derekhiggins Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit 5775e80)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on additional images in operator. This commit replaces base image for initContainers with main container's base image. This removes dependency of any additional images in disconnected environments