ci: introduce a pre-commit check and contributing doc

[leseb]

This CI check replaces the linter action, it has been included into the pre-commit hook.
The hook has 2 specialized ones:

• the go linter
• the generate manifest artifacts

You can run pre-commit locally:

pre-commit run --all-files

You can also install it so it will run before committing code.

pre-commit install

[leseb]

I think there is a back and forth between our local golang versions. @VaishnaviHire

[VaishnaviHire]

Yeah looks like it. Maybe just updating the go-lint version should suffice.

[rhuss]

Looks good to me. Could you briefly elaborate the benefit of pre-commit in addition to make lint as this is an additional development dependency that needs to be installed ?

Another idea, would to describe in CONTRIBUTING.md how to install it as a local pre-commit hook for git, so that it is automatically called on a git commit (or is this too much and we want to keep more control when to run the hook ?). Maybe there's something like a 'pre push' hook ?

Another comment is about the role.yaml file as it still looks weird to me. I wonder whether we should careful go through it and drill it down to the stuff that we really need. E.g. we don't need to list Services, or do we ? But that's a question for another PR.

[leseb]

Looks good to me. Could you briefly elaborate the benefit of pre-commit in addition to make lint as this is an additional development dependency that needs to be installed ?

As explained in the CONTRIBUTING guide, installing pre-commit locally is optional, it's up to the developers. But it's nice to have a common tool to run locally what the CI does in an all in one fashion. Also, when setup correctly, it will prevent developers from pushing inadequate content and save CI cycles.

Another idea, would to describe in CONTRIBUTING.md how to install it as a local pre-commit hook for git, so that it is automatically called on a git commit (or is this too much and we want to keep more control when to run the hook ?). Maybe there's something like a 'pre push' hook ?

This is what pre-commit install does, it configure it as a git hook to run on every commit.
I personally use it as a pre-push but again, it's up to the developer's preference.

Another comment is about the role.yaml file as it still looks weird to me. I wonder whether we should careful go through it and drill it down to the stuff that we really need. E.g. we don't need to list Services, or do we ? But that's a question for another PR.

I have the same feeling, but all those things were auto-generated :(

[rhuss]

Thanks @leseb for the elaboration, looks good to me!

For the role issue I've opened #18

/lgtm

[rhuss]

lgtm