test: remove ollama distribution testing, replace with starter #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derekhiggins
requested review from
VaishnaviHire,
cdoern,
leseb,
mfleader,
nathan-weinberg,
rhdedgar and
rhuss
as code owners
derekhiggins
force-pushed
the
test-multi-distros
branch
from
e018d89 to
2bfe2dc
Compare
|
Nice work 👍🏽 LGTM I am not in OWNERS here yet :) |
leseb
reviewed
Sep 16, 2025
derekhiggins
force-pushed
the
test-multi-distros
branch
from
2bfe2dc to
41ca570
Compare
derekhiggins
changed the title
rhdedgar
approved these changes
Sep 16, 2025
leseb
approved these changes
Sep 16, 2025
| }) | ||
| // Run combined creation and deletion tests for multiple distributions | ||
| // starter: newer image currently being actively updated | ||
| distributions := []string{"starter"} |
There was a problem hiding this comment.
Would be nice to be able to detect the distro instead of having to change that code. Improvement for later I suppose.
Restructure the creation test to run creation followed by deletion in a single test suite. This enables testing multiple distribution images sequentially with proper cleanup between runs. Changes: - Add TestCreationDeletionSuite that runs creation then deletion - Replace TestDeletionSuite with runDeletionTests helper function - Simplify test structure while maintaining all existing functionality Signed-off-by: Derek Higgins <derekh@redhat.com>
This focuses testing on the actively maintained starter distribution while removing support for the older ollama image that's no longer updated. Also intrduces a list of distro images (currently only 1) that can be tested. Signed-off-by: Derek Higgins <derekh@redhat.com>
derekhiggins
force-pushed
the
test-multi-distros
branch
from
41ca570 to
27ff770
Compare
derekhiggins
removed request for
VaishnaviHire,
cdoern,
mfleader,
nathan-weinberg and
rhuss
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…stack#160) test: remove ollama distribution testing, replace with starter This focuses testing on the actively maintained starter distribution while removing support for the older ollama image that's no longer updated. Also intrduces a list of distro images (currently only 1) that can be tested. --- test: combine creation and deletion into single lifecycle test Restructure the creation test to run creation followed by deletion in a single test suite. This enables testing multiple distribution images sequentially with proper cleanup between runs. Changes: - Add TestCreationDeletionSuite that runs creation then deletion - Replace TestDeletionSuite with runDeletionTests helper function - Simplify test structure while maintaining all existing functionality Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit f65cb85)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…stack#160) test: remove ollama distribution testing, replace with starter This focuses testing on the actively maintained starter distribution while removing support for the older ollama image that's no longer updated. Also intrduces a list of distro images (currently only 1) that can be tested. --- test: combine creation and deletion into single lifecycle test Restructure the creation test to run creation followed by deletion in a single test suite. This enables testing multiple distribution images sequentially with proper cleanup between runs. Changes: - Add TestCreationDeletionSuite that runs creation then deletion - Replace TestDeletionSuite with runDeletionTests helper function - Simplify test structure while maintaining all existing functionality Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit f65cb85)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
…stack#160) test: remove ollama distribution testing, replace with starter This focuses testing on the actively maintained starter distribution while removing support for the older ollama image that's no longer updated. Also intrduces a list of distro images (currently only 1) that can be tested. --- test: combine creation and deletion into single lifecycle test Restructure the creation test to run creation followed by deletion in a single test suite. This enables testing multiple distribution images sequentially with proper cleanup between runs. Changes: - Add TestCreationDeletionSuite that runs creation then deletion - Replace TestDeletionSuite with runDeletionTests helper function - Simplify test structure while maintaining all existing functionality Approved-by: rhdedgar Approved-by: leseb (cherry picked from commit f65cb85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.