Add Service Endpoint to LlamaStackDistribution .status #162
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianZaccaria
requested review from
VaishnaviHire,
cdoern,
derekhiggins,
leseb,
mfleader,
nathan-weinberg,
rhdedgar and
rhuss
as code owners
ChristianZaccaria
force-pushed
the
service-endpoint-status
branch
2 times, most recently
from
abcf933 to
9c3e2d6
Compare
5 tasks
|
@ChristianZaccaria please run pre-commit locally and repush. Thanks |
ChristianZaccaria
force-pushed
the
service-endpoint-status
branch
from
9c3e2d6 to
3ad1e75
Compare
Signed-off-by: ChristianZaccaria <christian.zaccaria.cz@gmail.com>
ChristianZaccaria
force-pushed
the
service-endpoint-status
branch
from
3ad1e75 to
7b6889b
Compare
|
Pre-commit seems to be stuck:
|
The workflows were awaiting approval |
Ohh I didn't know that, thanks @derekhiggins ! |
leseb
approved these changes
Sep 18, 2025
|
Confirmed working in CI
|
derekhiggins
approved these changes
Sep 18, 2025
leseb
removed request for
VaishnaviHire,
cdoern,
mfleader,
nathan-weinberg,
rhdedgar and
rhuss
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
## Description The `.status.serviceURL` field in the `LlamaStackDistribution` resource would now have the value i.e.,: ``` http://<service-name>.<namespace>.svc.cluster.local:<port> ``` Note: the pre-commit linter seems to not like the use of `serviceUrl`. It said to use `serviceURL` instead. ## Verification Steps I tested the service by: 1. Running my own version of llama-stack-k8s-operator on OpenShift with the changes in this PR: `make deploy IMG=quay.io/rh_ee_czaccari/llama-stack-k8s-operator:servicestatus4` 2. Created a sample LlamaStackDistribution. 3. Then I ran a test pod: >kubectl run curl-test --image=quay.io/rh_ee_czaccari/curl:test5 --rm -it --restart=Never -n ollama-dist -- curl -k -v http://llamastackdistribution-sample-service.ollama-dist.svc.cluster.local:8321/v1/models Approved-by: leseb Approved-by: derekhiggins (cherry picked from commit f2e783f)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
## Description The `.status.serviceURL` field in the `LlamaStackDistribution` resource would now have the value i.e.,: ``` http://<service-name>.<namespace>.svc.cluster.local:<port> ``` Note: the pre-commit linter seems to not like the use of `serviceUrl`. It said to use `serviceURL` instead. ## Verification Steps I tested the service by: 1. Running my own version of llama-stack-k8s-operator on OpenShift with the changes in this PR: `make deploy IMG=quay.io/rh_ee_czaccari/llama-stack-k8s-operator:servicestatus4` 2. Created a sample LlamaStackDistribution. 3. Then I ran a test pod: >kubectl run curl-test --image=quay.io/rh_ee_czaccari/curl:test5 --rm -it --restart=Never -n ollama-dist -- curl -k -v http://llamastackdistribution-sample-service.ollama-dist.svc.cluster.local:8321/v1/models Approved-by: leseb Approved-by: derekhiggins (cherry picked from commit f2e783f)
VaishnaviHire
pushed a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 18, 2025
## Description The `.status.serviceURL` field in the `LlamaStackDistribution` resource would now have the value i.e.,: ``` http://<service-name>.<namespace>.svc.cluster.local:<port> ``` Note: the pre-commit linter seems to not like the use of `serviceUrl`. It said to use `serviceURL` instead. ## Verification Steps I tested the service by: 1. Running my own version of llama-stack-k8s-operator on OpenShift with the changes in this PR: `make deploy IMG=quay.io/rh_ee_czaccari/llama-stack-k8s-operator:servicestatus4` 2. Created a sample LlamaStackDistribution. 3. Then I ran a test pod: >kubectl run curl-test --image=quay.io/rh_ee_czaccari/curl:test5 --rm -it --restart=Never -n ollama-dist -- curl -k -v http://llamastackdistribution-sample-service.ollama-dist.svc.cluster.local:8321/v1/models Approved-by: leseb Approved-by: derekhiggins (cherry picked from commit f2e783f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
.status.serviceURLfield in theLlamaStackDistributionresource would now have the value i.e.,:Note: the pre-commit linter seems to not like the use of
serviceUrl. It said to useserviceURLinstead.Verification Steps
I tested the service by:
make deploy IMG=quay.io/rh_ee_czaccari/llama-stack-k8s-operator:servicestatus4