chore: Ensure installer script is updated with manifests #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leseb
reviewed
May 19, 2025
.pre-commit-config.yaml
Outdated
| - id: generate-manifests | ||
| name: Generate Manifests | ||
| entry: make generate manifests | ||
| entry: make generate manifests build-installer |
There was a problem hiding this comment.
For troubleshooting purposes, I believe it would be clearer to have separate hooks for each case. This way, it’s easier to identify which make command failed.
There was a problem hiding this comment.
Makes sense, updated
Signed-off-by: Vaishnavi Hire <vhire@redhat.com>
leseb
approved these changes
May 20, 2025
|
|
||
| - repo: local | ||
| hooks: | ||
| - id: build-installer |
There was a problem hiding this comment.
Nit: since it's a local hook, you can put it inside the previous one. We should move all the local hooks under a single "repo: local". Followup PR
AjayJagan
referenced
this pull request
in AjayJagan/llama-stack-k8s-operator
Aug 14, 2025
…95f920 (opendatahub-io#34) Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com> Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
VaishnaviHire
added a commit
to VaishnaviHire/llama-stack-k8s-operator
that referenced
this pull request
Sep 22, 2025
Sync changes for 2.25 release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated pre-commit hook to update Installer script on manifest generation