Skip to content

Add support for additional fields #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 19, 2025
Merged

Add support for additional fields #72

merged 1 commit into from
Jun 19, 2025

Conversation

@VaishnaviHire
Copy link
Collaborator

This commit allows users to include additional fields like annotations, sidecars, labels in server deployment

This change is needed to support adding otel sidecar and annotations for observability

@VaishnaviHire
Add support for additional fields
4588c68 
This commit allows users to include additional fields like annotations, sidecars, labels
in server deployment

Signed-off-by: Vaishnavi Hire <vhire@redhat.com>
@VaishnaviHire VaishnaviHire requested a review from leseb June 18, 2025 21:54
@VaishnaviHire VaishnaviHire mentioned this pull request Jun 18, 2025
Merged
3 tasks
leseb
leseb reviewed Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this essentially preserves annotations that were previously set right? It's unclear from the PR description :)

leseb
leseb approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@leseb leseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all other Apply* deserve a similar treatment. We can do this in a followup PR.

@mergify mergify bot merged commit 50338b6 into llamastack:main Jun 19, 2025
6 checks passed
@leseb leseb mentioned this pull request Jun 19, 2025
Open
@VaishnaviHire
Copy link
Collaborator Author

I think all other Apply* deserve a similar treatment. We can do this in a followup PR.
Yes. I think these will be addressed anyways in follow-ups to #54

VaishnaviHire added a commit to VaishnaviHire/llama-stack-k8s-operator that referenced this pull request Jun 20, 2025
@VaishnaviHire
Add support for additional fields (llamastack#72)
b092a07 
This commit allows users to include additional fields like annotations, sidecars, labels in server deployment

This change is needed to support adding `otel` sidecar and annotations for observability


Approved-by: leseb
VaishnaviHire added a commit to opendatahub-io/llama-stack-k8s-operator that referenced this pull request Jun 20, 2025
@VaishnaviHire
Merge pull request #12 from VaishnaviHire/update_2.22_fix
edb5f84 
[odh] Sync: Add support for additional fields (llamastack#72)
VaishnaviHire pushed a commit to VaishnaviHire/llama-stack-k8s-operator that referenced this pull request Oct 6, 2025
@konflux-internal-p02
chore(deps): update konflux references (llamastack#72)
1a2e9c4 
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leseb leseb leseb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VaishnaviHire @leseb