Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled clicking on abacus beads to move it #146 #181

Closed
wants to merge 2 commits into from
Closed

Enabled clicking on abacus beads to move it #146 #181

wants to merge 2 commits into from

Conversation

aditigupta17
Copy link

@aditigupta17 aditigupta17 commented Jan 15, 2018

Earlier, the user had to drag the beads, now a single click sends the beads up and double-clicking on them brings them down.
peek 2018-01-15 20-54

Earlier, the user had to drag the beads, now a single click sends the beads up and double-clicking on them brings them down.
@llaske
Copy link
Owner

llaske commented Jan 24, 2018

Nice work but using double-click is a problem because it will not work on touch screen.
Another idea ?

@aditigupta17
Copy link
Author

Oh yeah, didn't see that..any suggestions from your side?

@aditigupta17
Copy link
Author

I just tried, it works well on touch screen as well, just double-tapping the bead is causing it to move down.

Single-click/tapping once causes the beads to move up and double-clicking/tapping twice moves them down
@llaske
Copy link
Owner

llaske commented Jan 27, 2018

Hmmm. Not sure double-tap is a intuitive gesture on touch screens.
Is there a way to compute automatically (by deduction) the direction expected by an user ? A sort of AI that could know that when you click it's for move up or down.
If it's possible to do that without any error, let's try this. Else we could propose an automatic move on click/tap when there is no doubt about the direction expected and let the drag gesture when it's not possible to do the deduction.
What do you think?

@aditigupta17
Copy link
Author

Ya, the latter sounds good. Working on it.

@ghost
Copy link

ghost commented Mar 1, 2018

Is there any other behavior associated with a single click or a touch (long or short) on a bead beyond moving it?

@aditigupta17
Copy link
Author

According to the changes made in the PR, a single click/tap should send the bead up and double click/double tap moves it down.

@ghost
Copy link

ghost commented Mar 4, 2018 via email

@aditigupta17
Copy link
Author

peek 2018-03-05 08-52
There are a few types of abacii, (like the one shown in the gif) in which beads can move in either direction. So to differentiate that, different gestures are needed.

@llaske
Copy link
Owner

llaske commented Mar 5, 2018

Thanks all for your analysis. So my first intuition is the right: we could propose an automatic move on click/tap when there is no doubt about the direction expected and let the drag gesture - since double-tap is not intuitive - when it's not possible to do the deduction.

@llaske
Copy link
Owner

llaske commented Feb 23, 2019

Fixed by #277

@llaske llaske closed this Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants