Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

created a chess activity #717

Closed
wants to merge 3 commits into from
Closed

created a chess activity #717

wants to merge 3 commits into from

Conversation

samcaspus
Copy link

created a chess activity against comp for Gsoc

@ashish0910
Copy link
Contributor

ashish0910 commented Mar 21, 2020

@samcaspus there are a lot of unnecessary changes . You don't have to add Pawn.Activity in this Pull request . There should only addition of Chess activity and it's addition in activities.json . Please do not add any other changes .

@samcaspus
Copy link
Author

samcaspus commented Mar 21, 2020

@ashish0910 Have made the base changes

@ashish0910
Copy link
Contributor

@samcaspus please remove Pawn Activity from pull request .

@samcaspus
Copy link
Author

@ashish0910 actually i have removed them if you see it says i have deleted all the files... let me know if i am interpreting it wrong.

@samcaspus
Copy link
Author

due to issues with regards to file I have create a new pull request fixing the issue here at #735 hope that fixes all the issues @ashish0910

@samcaspus samcaspus closed this Mar 24, 2020
@quozl
Copy link

quozl commented Mar 24, 2020

@samcaspus, while deleting your repository and starting again with a new clone, as you have done, can work, a more usual method is to fix the problem in the branch you are working on. Next time, you might do better, by using git features, after searching for solutions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants