Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MindMath Activity #817

Merged
merged 55 commits into from Jul 21, 2020
Merged

MindMath Activity #817

merged 55 commits into from Jul 21, 2020

Conversation

prakashujjwal1010
Copy link
Contributor

In progress, MindMath activity for GSOC 2020

@llaske
Copy link
Owner

llaske commented Jun 25, 2020

Nice.
Few UI remarks:

  • Sounds like the font is not set, look like the default browser font is use
  • Avoid displaying buttons or UI elements not usable. For example all these elements (including the 1/1) should be hidden instead of disable

image

image

@llaske
Copy link
Owner

llaske commented Jun 25, 2020

Two other remarks resulting to our demo session:

  • Do not combine pagination and scrollbar on the result and scoreboard screen. Just use pagination.
  • Replace "--" in scoreboard screen when an user is playing by a hourglass icon

@llaske
Copy link
Owner

llaske commented Jul 1, 2020

Few remarks on your latest PR:

  • In Result screen, there is an alignment issue with buttons in the footer : back arrow and restart button are not vertically aligned with other buttons

Capture d’écran du 2020-07-01 22-02-41

  • In Result screen, the scrollbar is still visible to the right
  • I'm not sure to understand the level of difficulty: easy level give higher number than difficult level
  • When button in tutorial are disabled, the font/background color use are not the right one

Capture d’écran du 2020-07-01 22-04-01
image

@prakashujjwal1010
Copy link
Contributor Author

prakashujjwal1010 commented Jul 1, 2020

well the difficulty level is like( as described here ):

  • an easy level with a chosen number between 10 and 69
  • a medium level with a chosen number between 0 and 99

However open to suggestions to change it, we can change the ranges.
fixed the allignment issue etc. and will look into fixing the tutorial disabled button issue.

@llaske
Copy link
Owner

llaske commented Jul 19, 2020

On remark: in "No Timer" mode it seems that there is no difference between the "Restart" button and the "Pass" button. If so, in this mode it could be interesting to hide the "Restart" button.

@prakashujjwal1010
Copy link
Contributor Author

yes, it sounds good.

@llaske llaske merged commit 023e597 into llaske:dev Jul 21, 2020
@llaske
Copy link
Owner

llaske commented Jul 21, 2020

Thanks a lot for your work.
This activity is very fun and addictive and the UI is pretty engaging.

@@ -95,7 +95,7 @@ var Game = {
</div>
<div class="slots-area-footer">
<button id="btn-restart"
v-if="!disabled"
v-if="!disabled && mode=='timer'"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens in multi-player mode? I guess it will hide the restart button too so it will forbid to hosting user to restart the game.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in multiplayer mode restart button would be in result screen. so it will not have a problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants