New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total requirements do not include Constants #158

Closed
cmb69 opened this Issue Jan 10, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@cmb69
Contributor

cmb69 commented Jan 10, 2015

There seems to be a regression in 3.7.2 (works fine with 3.7.1), so that the Total doesn't include the Constants.

Test script:

<?php

echo PHP_EOL;
mb_strtolower($text);

Output:

Data Source Analysed

Directories                                          1
Files                                                1

Global Analysis

                    Count Cond PHP min Elements highlight
 Extensions         2     0    4.3.10  Core
 Namespaces         1     0    4.3.0   +global
 Interfaces         0     0
 Traits             0     0
 Classes            0     0
 User Functions     0     0
 Internal Functions 1     0    4.3.0   mb_strtolower
 Constants          1     0    4.3.10  PHP_EOL
 Total                         4.3.0
@llaville

This comment has been minimized.

Owner

llaville commented Jan 13, 2015

I finally found origin of regression due to commit dbda65a#diff-9e696e6927eb42cc9053c00ab419b201

The control on lines 681 - 683 is at wrong location and is in conflict with visitConstantModel that can't do its job

llaville added a commit that referenced this issue Jan 13, 2015

@llaville

This comment has been minimized.

Owner

llaville commented Jan 13, 2015

As new API 4.0 is not impacted by this issue, I'll attach to milestone 3.7.3 (no due date).

@llaville llaville added this to the 3.7.3 milestone Jan 13, 2015

@llaville llaville closed this Jan 13, 2015

llaville added a commit that referenced this issue Jan 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment