Prior to PHP 5.5, empty() only supports variables #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test if the parameter of empty() is an arbitrary expression, and not just a variable.
| @@ -332,6 +332,9 @@ public function leaveNode(Node $node) | |||
|
|
|||
| } elseif ($node instanceof Node\Scalar\MagicConst) { | |||
| $this->computeConstantVersions($node, $node->getName()); | |||
|
|
|||
| } else if ( $node instanceof Node\Expr\Empty_ ) { | |||
|
For documentation, here is the link http://www.php.net/manual/en/migration55.new-features.php#migration55.new-features.empty I need to create a test unit for quality assurance. Will do it tomorrow |
llaville
added a commit
that referenced
this pull request
Jul 15, 2015
llaville
added a commit
that referenced
this pull request
Jul 15, 2015
Prior to PHP 5.5, empty() only supports variables
|
Release 4.4.1 is planned for saturday morning (July 18). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test if the parameter of empty() is an arbitrary expression, and not
just a variable.