Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix failed tests because of file order #16

Merged
merged 1 commit into from Jan 5, 2015
Merged

Conversation

@remicollet
Copy link
Contributor

remicollet commented Jan 5, 2015

No description provided.

@llaville

This comment has been minimized.

Copy link
Owner

llaville commented Jan 5, 2015

Can you provide results of tests ! I got no failure on my side

PHPUnit 4.4.1 by Sebastian Bergmann.

Configuration read from C:\home\github\php-reflect\phpunit.xml.dist

...............................................................  63 / 170 ( 37%)
............................................................... 126 / 170 ( 74%)
............................................

Time: 3.69 seconds, Memory: 10.00Mb

OK (170 tests, 171 assertions)

BTW, I can't accept this patch because it will pick all files in _files folder, and the test is only for two files

@remicollet

This comment has been minimized.

Copy link
Contributor Author

remicollet commented Jan 5, 2015

Without the patch

 + /usr/bin/phpunit
 PHPUnit 4.4.1 by Sebastian Bergmann.
 Configuration read from /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/phpunit.xml.dist
 ...............................................................  63 / 170 ( 37%)
 ............................................................... 126 / 170 ( 74%)
 ............................FFFF............
 Time: 437 ms, Memory: 16.25Mb
 There were 4 failures:
 1) Bartlett\Tests\Reflect\PhpFeature\V504Test::testClassMemberAccessOnDirectInstantiation
 array('one', 'two', 'three') is not a class member access on direct instantiation.
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'ClassMemberAccessOnDirectInstantiation'
 +'ArrayShortSyntax'
 /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/tests/PhpFeature/V504Test.php:99
 2) Bartlett\Tests\Reflect\PhpFeature\V504Test::testClassMemberAccessOnIndirectInstantiation
 (new Foo())->bar() is not a class member access on indirect instantiation.
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'ClassMemberAccessOnIndirectInstantiation'
 +'ClassMemberAccessOnDirectInstantiation'
 /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/tests/PhpFeature/V504Test.php:117
 3) Bartlett\Tests\Reflect\PhpFeature\V504Test::testArrayShortSyntax
 (new $a())->bar() is not a short array syntax.
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'ArrayShortSyntax'
 +'ClassMemberAccessOnIndirectInstantiation'
 /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/tests/PhpFeature/V504Test.php:135
 4) Bartlett\Tests\Reflect\PhpFeature\V504Test::testArrayDereferencing
 (new $a('Baz'))->bar() is not an array dereferencing.
 Failed asserting that two strings are equal.
 --- Expected
 +++ Actual
 @@ @@
 -'ArrayDereferencing'
 +'ClassMemberAccessOnIndirectInstantiation'
 /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/tests/PhpFeature/V504Test.php:153
 FAILURES!
 Tests: 170, Assertions: 171, Failures: 4.

With the patch

 + /usr/bin/phpunit
 PHPUnit 4.4.1 by Sebastian Bergmann.
 Configuration read from /dev/shm/BUILD/php-reflect-6b059b7106c74e9db5d7dd84c2995eb6fe678331/phpunit.xml.dist
 ...............................................................  63 / 170 ( 37%)
 ............................................................... 126 / 170 ( 74%)
 ............................................
 Time: 441 ms, Memory: 16.25Mb
 OK (170 tests, 171 assertions)
@llaville

This comment has been minimized.

Copy link
Owner

llaville commented Jan 5, 2015

Sorry Remi, I don't read the patch as it should be (forgot my previous comment) . I agree

llaville added a commit that referenced this pull request Jan 5, 2015
fix failed tests because of file order
@llaville llaville merged commit d56bb6a into llaville:master Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.