Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle message edit and delete #79

Closed
wants to merge 2 commits into from

Conversation

llimllib
Copy link
Owner

Previously, I had banned handling message editing because limbo's
messages are echoed back as message edits and it was an easy way to
ignore our own messages to prevent message loops.

  • Handle message update and delete
    • use the on_message_changed and on_message_deleted functions to
      handle them, respectively
  • test message update and delete
  • add user id to slack server
    • may be useful in the future, easy to add
  • return to manually checking for self messages and slackbot messages
    • do people want to handle slackbot messages in plugins?
  • clean up handle_message

Fixes #78

Previously, I had banned handling message editing because limbo's
messages are echoed back as message edits and it was an easy way to
ignore our own messages to prevent message loops.

* Handle message update and delete
    * use the `on_message_changed` and `on_message_deleted` functions to
      handle them, respectively
* test message update and delete
* add user id to slack server
    * may be useful in the future, easy to add
* return to manually checking for self messages and slackbot messages
    * do people want to handle slackbot messages in plugins?
* clean up handle_message

Fixes #78
@llimllib llimllib closed this Dec 10, 2016
@llimllib llimllib deleted the handle-message-edit-and-delete branch December 10, 2016 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant