Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use jpeg instead of jpg, use enums instead of strings #2453

Merged
merged 3 commits into from
Mar 9, 2024

Conversation

mashb1t
Copy link
Collaborator

@mashb1t mashb1t commented Mar 5, 2024

Reasoning:

  1. we're already using jpeg to save a jpg file and should sync the filetype accordingly to support more features.
    .jpg is just a compatible form for older OS which only support 3 characters for file extensions.
  2. enums allow for less typos in strings and allow the actual value behind the enum option to be changed if needed.

mashb1t and others added 3 commits March 4, 2024 11:37
fixes an issue with A1111 metadata scheme where width and height are strings after splitting resolution
@mashb1t mashb1t requested a review from lllyasviel as a code owner March 5, 2024 17:48
@mashb1t mashb1t added the Size S small change, basically no testing needed label Mar 5, 2024
@mashb1t mashb1t changed the base branch from main to develop March 9, 2024 14:59
@mashb1t mashb1t merged commit b6e4bb8 into develop Mar 9, 2024
@mashb1t mashb1t deleted the feature/enum-refactoring branch March 9, 2024 15:00
@mashb1t mashb1t added this to the 2.3.0 (draft) milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size S small change, basically no testing needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant