Skip to content

Conversation

@lloc
Copy link
Owner

@lloc lloc commented Dec 7, 2025

Fixes #545

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @lloc, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request delivers version 2.10.1 of the Multisite Language Switcher plugin, focusing on critical maintenance, enhanced compatibility, and internal code quality. It addresses a deprecated function warning, updates documentation, refines language flag data, and ensures robustness with modern PHP versions through targeted refactoring and new unit tests.

Highlights

  • Version Update and Changelog: The plugin has been updated to version 2.10.1. The changelog now includes entries for both 2.10.1 (addressing a deprecated function warning and documentation updates) and 2.10.0 (introducing new prefixed helper functions with backward compatibility shims, exposing action hook names as constants, adding accessibility features, resolving path issues, and performing internal restructuring and dependency updates).
  • Deprecated Function Management: Deprecated functions have been updated to correctly reference their new prefixed equivalents (e.g., msls_get_switcher, msls_the_switcher), and their deprecation notices now specify version 2.10.1. Comprehensive unit tests have been added to ensure these deprecated functions behave as expected and issue proper warnings.
  • PHP 8 Compatibility and Internal Refactoring: The uninstall method has been refactored to use a void return type, aligning with modern PHP type hinting. Additionally, unit tests for MslsRequest have been enhanced to ensure proper handling of null returns for input constants removed in PHP 8, improving overall compatibility.
  • Localization Data and Documentation Refresh: Language flag data files (assets/css-flags/flags.php and assets/flags/flags.php) have been cleaned up and reordered for consistency. The README.md documentation has been updated to reflect the new function names, and the build/translations.json file has been refreshed with the latest WordPress translation versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the plugin to version 2.10.1, addressing a bug with deprecated function warnings and updating documentation. The changes are mostly version bumps and minor refactorings. I've found a few issues: a typo in a filename, a typo in a test method name, and a regression in test coverage where assertions on return values were removed. Please see my detailed comments.

@lloc lloc merged commit f04b603 into master Dec 8, 2025
6 checks passed
@lloc lloc deleted the dev/feature/version-2.10.1 branch December 8, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation message of function 'the_msls' points to new function name 'msls_the_msls()' which does not exist

2 participants