Improve 'frunk', 'frunk_core', and 'frunk_derives' package metadata. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added `documentation` key to rendering of documentation for latest published version of this crate. Renamed `homepage` key to `repository`. Added `badges` table and `travis-ci` item.
lloydmeta
requested changes
Mar 16, 2017
Cargo.toml
Outdated
| @@ -4,9 +4,13 @@ version = "0.1.19" | |||
| authors = ["Lloyd <lloydmeta@gmail.com>"] | |||
| description = "Frunk provides developers with a number of functional programming tools like HList, Generic, LabelledGeneric, Validated, Monoid, Semigroup and friends." | |||
| license = "MIT" | |||
| homepage = "https://github.com/lloydmeta/frunk" | |||
| documentation = "https://docs.rs/frunk/0.1.19/frunk/" | |||
There was a problem hiding this comment.
It looks like we can leave off the part of the path that deals with versioning (e.g. https://docs.rs/frunk) so that we can always just look at the latest published version. A bit less to maintain :)
core/Cargo.toml
Outdated
| documentation = "https://docs.rs/frunk_core/0.0.9/frunk_core/" | ||
| repository = "https://github.com/lloydmeta/frunk" | ||
| keywords = [ "HList", "Generic"] |
There was a problem hiding this comment.
Might be nice to add LabelledGeneric to this as well.
core/Cargo.toml
Outdated
| documentation = "https://docs.rs/frunk_core/0.0.9/frunk_core/" |
There was a problem hiding this comment.
https://docs.rs/frunk_core should be fine I think.
derives/Cargo.toml
Outdated
| @@ -4,9 +4,13 @@ version = "0.0.10" | |||
| authors = ["Lloyd <lloydmeta@gmail.com>"] | |||
| description = "frunk_derives contains the custom derivations for certain traits in Frunk." | |||
| license = "MIT" | |||
| homepage = "https://github.com/lloydmeta/frunk" | |||
| documentation = "https://docs.rs/frunk_derives/0.0.10/frunk_derives/" | |||
There was a problem hiding this comment.
https://docs.rs/frunk_derives will look up the latest published version.
derives/Cargo.toml
Outdated
| @@ -4,9 +4,13 @@ version = "0.0.10" | |||
| authors = ["Lloyd <lloydmeta@gmail.com>"] | |||
| description = "frunk_derives contains the custom derivations for certain traits in Frunk." | |||
| license = "MIT" | |||
| homepage = "https://github.com/lloydmeta/frunk" | |||
| documentation = "https://docs.rs/frunk_derives/0.0.10/frunk_derives/" | |||
| repository = "https://github.com/lloydmeta/frunk" | |||
| keywords = [ "HList", "Generic", "derives"] | |||
There was a problem hiding this comment.
I know you didn't touch this, but maybe we can either delete Hlist and Generic from here or get rid of keywords altogether.
Removed "HList" and generic "Generic" from frunk_derives manifest. Added "Frunk" as a keyword to each package, following the convention of serde.
lloydmeta
approved these changes
Mar 16, 2017
|
Perfect this looks great. Thanks again ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
documentationkey to rendering of documentation for latest published version of each crate. Renamedhomepagekey torepository. Addedbadgestable andtravis-ciitem.