Permalink
Browse files

Simplify function try/catch scope handling.

Based on post-commit review feedback for r167766 by Richard Smith.

git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@167856 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information...
1 parent b55c67d commit e5afdcfd6a80efc20b0a2e5bde806c08c3bda887 @dwblaikie dwblaikie committed Nov 13, 2012
Showing with 4 additions and 13 deletions.
  1. +1 −10 include/clang/Sema/Scope.h
  2. +3 −3 lib/Parse/ParseStmt.cpp
View
@@ -84,18 +84,9 @@ class Scope {
/// TryScope - This is the scope of a C++ try statement.
TryScope = 0x1000,
- /// CatchScope - This is the scope of a C++ catch statement.
- CatchScope = 0x2000,
-
/// FnTryCatchScope - This is the scope for a function-level C++ try or
/// catch scope.
- FnTryCatchScope = 0x4000,
-
- /// FnTryScope - This is the scope of a function-level C++ try scope.
- FnTryScope = TryScope | FnTryCatchScope,
-
- /// FnCatchScope - This is the scope of a function-level C++ catch scope.
- FnCatchScope = CatchScope | FnTryCatchScope
+ FnTryCatchScope = 0x2000
};
private:
/// The parent scope for this scope. This is null for the translation-unit
View
@@ -2123,8 +2123,8 @@ StmtResult Parser::ParseCXXTryBlockCommon(SourceLocation TryLoc, bool FnTry) {
// FIXME: Possible draft standard bug: attribute-specifier should be allowed?
StmtResult TryBlock(ParseCompoundStatement(/*isStmtExpr=*/false,
- Scope::DeclScope |
- (FnTry ? Scope::FnTryScope : Scope::TryScope)));
+ Scope::DeclScope | Scope::TryScope |
+ (FnTry ? Scope::FnTryCatchScope : 0)));
if (TryBlock.isInvalid())
return TryBlock;
@@ -2197,7 +2197,7 @@ StmtResult Parser::ParseCXXCatchBlock(bool FnCatch) {
// The name in a catch exception-declaration is local to the handler and
// shall not be redeclared in the outermost block of the handler.
ParseScope CatchScope(this, Scope::DeclScope | Scope::ControlScope |
- (FnCatch ? Scope::FnCatchScope : Scope::CatchScope));
+ (FnCatch ? Scope::FnTryCatchScope : 0));
// exception-declaration is equivalent to '...' or a parameter-declaration
// without default arguments.

0 comments on commit e5afdcf

Please sign in to comment.