Skip to content

Conversation

@CodaFi
Copy link
Member

@CodaFi CodaFi commented Feb 13, 2017

  • Cleans up a bit of documentation (removes some LLVM-isms)
  • Extends the regex parser to search for closing }} in regex patterns only after chewing on any balanced set of brackets inside the pattern. Notably, this makes {m, n}-style quantifiers unambiguous and should be upstreamed into FileCheck proper.
  • Converts some (Int, Int)? to NSRange?
  • When a regex parses successfully but fails to match, FileCheck dumps an error instead of crashing.

@CodaFi
Copy link
Member Author

CodaFi commented Feb 13, 2017

⛵️

@CodaFi CodaFi merged commit 0b8bc56 into llvm-swift:master Feb 13, 2017
@CodaFi CodaFi deleted the dont-write-filechecks-your-mouth-cant-cash branch February 13, 2017 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant