Model Call and Invoke as higher-level structures

[CodaFi]

Only controversial thing could be the use of subscript to retrieve the alignment of parameters. This can always be remodeled as a property that returns a sequence or collection that wraps a sequence that accesses these values, but I'm not sure that's a cleaner model than this.

[harlanhaskins]

LGTM modulo that change

[CodaFi]

Did you mean to follow through with that change-the-subscripts comment? Have an API in mind here?

[harlanhaskins]

Well, basically there's nothing that tells me that call[2] is going to let me set an alignment.

[CodaFi]

public func parameterAlignment(at i : Int) -> Int

[CodaFi]

Or...

public func setParameterAlignment(at i : Int, to alignment: Int) {
    LLVMSetInstrParamAlignment(self.llvm, UInt32(i), UInt32(alignment))
  }

[harlanhaskins]

Definitely setParameterAlignment(at:)

[CodaFi]

⛵️