Skip to content

A Hodge-Podge of Fixes and Features #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 7, 2017
Merged

A Hodge-Podge of Fixes and Features #98

merged 5 commits into from
Sep 7, 2017

Conversation

@CodaFi
Copy link
Member

@CodaFi CodaFi commented Sep 6, 2017 •
edited
Loading

  • Renames threadLocalMode to threadLocalModel - LLVM is wrong, not us.
  • Adds an accessor to Switch instructions to get the default block
  • Add atomic ordering parameters to memory access instructions
  • Add volatility parameters to memory access instructions
  • Add constant inline assembly references. Note that this is different from module-level inline assembly and should only be done when constructing IR inside a function.

(Support for module-level ASM is tricky without a better C API)

harlanhaskins
harlanhaskins reviewed Sep 6, 2017
View reviewed changes
Sources/LLVM/IRBuilder.swift
///
/// - returns: A representation of the newly created inline assembly
/// expression.
public func buildInlineAssembly(_ asm: String, type: FunctionType, constraints: String = "", hasSideEffects: Bool = true, needsAlignedStack: Bool = true) -> IRValue {
Copy link
Member

@harlanhaskins harlanhaskins Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a URL we can point to for more information? Or is this documentation already better than the existing LLVM doc...?

Copy link
Member Author

@CodaFi CodaFi Sep 6, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of is LLVM's docs on this. Paraphrased and updated a bit with references to external stuff.

@harlanhaskins
Copy link
Member

harlanhaskins commented Sep 6, 2017

LGTM!

@CodaFi
Fix atomic ordering accessor
9aa43f3 
Use the derived ==.  Providing our own causes a
cyclic dependency on the ordering -> LLVM map
which causes crashes on recursive initial accesses
to the dictionary.
segiddins
segiddins approved these changes Sep 6, 2017
View reviewed changes
Copy link
Contributor

@segiddins segiddins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@CodaFi
Copy link
Member Author

CodaFi commented Sep 7, 2017

⛵️

@CodaFi CodaFi merged commit 7dd5dbc into llvm-swift:master Sep 7, 2017
@CodaFi CodaFi deleted the parody branch September 7, 2017 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harlanhaskins harlanhaskins harlanhaskins approved these changes

@segiddins segiddins segiddins approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@CodaFi @harlanhaskins @segiddins