From 01d449503248bac6f9bcb6e1214a1a30c6153cde Mon Sep 17 00:00:00 2001 From: xlauko Date: Sun, 5 Oct 2025 20:03:44 +0200 Subject: [PATCH] [CIR][NFC] Clean up constant op comments --- clang/include/clang/CIR/Dialect/IR/CIROps.td | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/clang/include/clang/CIR/Dialect/IR/CIROps.td b/clang/include/clang/CIR/Dialect/IR/CIROps.td index 30c09bfe2bfa..4def17cd38e7 100644 --- a/clang/include/clang/CIR/Dialect/IR/CIROps.td +++ b/clang/include/clang/CIR/Dialect/IR/CIROps.td @@ -473,28 +473,23 @@ def CIR_PtrStrideOp : CIR_Op<"ptr_stride",[ def CIR_ConstantOp : CIR_Op<"const",[ ConstantLike, Pure, AllTypesMatch<["value", "res"]> ]> { - // FIXME: Use SameOperandsAndResultType or similar and prevent eye bleeding - // type repetition in the assembly form. - - let summary = "Defines a CIR constant"; + let summary = "Create a CIR constant from a literal attribute"; let description = [{ The `cir.const` operation turns a literal into an SSA value. The data is attached to the operation as an attribute. ```mlir - %0 = cir.const 42 : i32 - %1 = cir.const 4.2 : f32 - %2 = cir.const nullptr : !cir.ptr + %0 = cir.const #cir.int<4> : !u32i + %1 = cir.const #cir.fp<1.500000e+00> : !cir.float + %2 = cir.const #cir.ptr : !cir.ptr ``` }]; - // The constant operation takes an attribute as the only input. let arguments = (ins TypedAttrInterface:$value); - // The constant operation returns a single value of CIR_AnyType. let results = (outs CIR_AnyType:$res); - let assemblyFormat = "attr-dict $value"; + let assemblyFormat = "$value attr-dict"; let hasVerifier = 1;