Skip to content
This repository has been archived by the owner. It is now read-only.

__cpp_lib_make_unique not defined in <memory> #38844

Closed
apolukhin mannequin opened this issue Sep 5, 2018 · 4 comments
Closed

__cpp_lib_make_unique not defined in <memory> #38844

apolukhin mannequin opened this issue Sep 5, 2018 · 4 comments
Assignees

Comments

@apolukhin
Copy link
Mannequin

@apolukhin apolukhin mannequin commented Sep 5, 2018

Bugzilla Link 38844
Resolution FIXED
Resolved on Feb 07, 2019 09:35
Version 7.0
OS Linux
CC @apolukhin,@dwblaikie,@mclow

Extended Description

Multiple projects suffer from that (see https://reviews.freebsd.org/rP460135 as an example).

Please add the following line

#define __cpp_lib_make_unique 201304

near make_unique definition.

@apolukhin
Copy link
Mannequin Author

@apolukhin apolukhin mannequin commented Sep 5, 2018

assigned to @mclow

Loading

@mclow
Copy link

@mclow mclow commented Sep 5, 2018

Currently, libc++ does not define any feature macros.

These were not required, but rather were advisory.
This will be changing for C++20 (see https://wg21.link/P0941)

Loading

@mclow
Copy link

@mclow mclow commented Sep 5, 2018

Currently, libc++ does not define any feature macros.

Ok, I was wrong. We define a couple.
Someone must have snuck them in when I wasn't paying close enough attention.

Loading

@mclow
Copy link

@mclow mclow commented Feb 7, 2019

This has been fixed.

Loading

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant