Skip to content
This repository has been archived by the owner. It is now read-only.

sanitizers broken on freebsd in 8.0.0-rc2 #40761

Closed
zmodem opened this issue Feb 18, 2019 · 17 comments
Closed

sanitizers broken on freebsd in 8.0.0-rc2 #40761

zmodem opened this issue Feb 18, 2019 · 17 comments

Comments

@zmodem
Copy link

@zmodem zmodem commented Feb 18, 2019

Bugzilla Link 40761
Resolution FIXED
Resolved on Aug 09, 2019 03:16
Version 8.0
OS FreeBSD
Blocks #41221 #42474
CC @arichardson,@DimitryAndric,@emaste,@seanm

Extended Description

Dimitry reported that the sanitizers are broken on FreeBsd in 8.0.0-rc2: http://lists.llvm.org/pipermail/llvm-dev/2019-February/130236.html

"Unfortunately I had to disable compiler-rt for this test run, as most of the sanitizers are totally broken. They get into an endless recursive loop between AsanTSDGet() and the __tls_get_addr() interceptor, and crash with DEADLYSIGNAL due to stack overflow. I haven't found the time to further diagnose this."

@zmodem
Copy link
Author

@zmodem zmodem commented Feb 18, 2019

Dimitry hit this and looked at it also in rc1: http://lists.llvm.org/pipermail/llvm-dev/2019-February/129906.html

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Feb 18, 2019

+emaste for more FreeBSD people.

I think this is currently the only hard blocked for the release. Do you think you'll have time to look into this any time soon, or do you know someone who could?

Loading

@llvmbot
Copy link
Collaborator

@llvmbot llvmbot commented Feb 19, 2019

It looks like this revision is related:

https://reviews.llvm.org/D55596 Reimplement Thread Static Data ASan routines with TLS

According to a tester it worked on FreeBSD. If you think that it has to be reverted for this OS, feel free to do it, but keep in mind that NetBSD must use the TLS version.

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Feb 20, 2019

Ed, Dimitry: ping? Do you think any of you will have to bisect or otherwise investigate this soon, or can you find someone who can work on it?

Loading

@DimitryAndric
Copy link

@DimitryAndric DimitryAndric commented Feb 20, 2019

Ed, Dimitry: ping? Do you think any of you will have to bisect or otherwise
investigate this soon, or can you find someone who can work on it?

I won't have time to work on it at all, unfortunately.

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Feb 22, 2019

http://lists.llvm.org/pipermail/release-testers/2019-February/000869.html has some details on the errors Dimitry was seeing.

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Feb 27, 2019

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Mar 8, 2019

Sadly we will have to release without fixes for this (see email threads). Unblocking.

Loading

@arichardson
Copy link
Member

@arichardson arichardson commented Jul 24, 2019

Loading

@arichardson
Copy link
Member

@arichardson arichardson commented Jul 25, 2019

Sorry that was the wrong URL. The proposed fix is https://reviews.llvm.org/D65221
If this is accepted we can hopefully get the fix into 9.0.

Loading

@arichardson
Copy link
Member

@arichardson arichardson commented Jul 31, 2019

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed to the release branch?

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Aug 1, 2019

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed
to the release branch?

Absolutely! Merged in r367524.

Dimitry: I hope this will make all tests in rc2.

Loading

@DimitryAndric
Copy link

@DimitryAndric DimitryAndric commented Aug 1, 2019

Fixed in https://reviews.llvm.org/rL367442. Could we also get this committed
to the release branch?

Absolutely! Merged in r367524.

Dimitry: I hope this will make all tests in rc2.

It looks promising, but I still have to apply a few fixes to make the sanitizer tests compile at all, and some lit-related fixups to make the dynamic library path stuff work. And TSan is still completely broken. I will follow up on the mailing list.

Loading

@arichardson
Copy link
Member

@arichardson arichardson commented Aug 3, 2019

Fix for TSAN on FreeBSD: https://reviews.llvm.org/D65705

Loading

@zmodem
Copy link
Author

@zmodem zmodem commented Aug 9, 2019

Fix for TSAN on FreeBSD: https://reviews.llvm.org/D65705

That landed in r368103 and was merged to release_90 in r368426.

Loading

@tstellar
Copy link

@tstellar tstellar commented Nov 27, 2021

mentioned in issue #41221

Loading

@tstellar
Copy link

@tstellar tstellar commented Nov 27, 2021

mentioned in issue #42474

Loading

This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants