From 7c2782e9975b6da2358908ded52ab7bb2e050b42 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 14 Oct 2025 07:51:42 -0400 Subject: [PATCH] Serialize installation tests Due to the way installation of the package works (based on setup.py), it creates temporary content in a build/ directory at the root of the repository. This sometimes causes installation to fail if another installation is happening at the same time, which is problematic for the client/server installation tests. Until we modernize to a proper pyproject.toml, serialize the installation tests to ensure they don't fail spuriously. --- tests/utils/installation-client.shtest | 8 -------- tests/utils/installation-server.shtest | 8 -------- tests/utils/installation.shtest | 17 +++++++++++++++++ 3 files changed, 17 insertions(+), 16 deletions(-) delete mode 100644 tests/utils/installation-client.shtest delete mode 100644 tests/utils/installation-server.shtest create mode 100644 tests/utils/installation.shtest diff --git a/tests/utils/installation-client.shtest b/tests/utils/installation-client.shtest deleted file mode 100644 index 35415e14..00000000 --- a/tests/utils/installation-client.shtest +++ /dev/null @@ -1,8 +0,0 @@ -# Check that installation using the client requirements works properly. -# -# RUN: rm -rf %t.venv -# RUN: python -m venv %t.venv -# RUN: cd %{src_root} -# RUN: %t.venv/bin/python -m pip install -r requirements.client.txt -# RUN: rm -rf %t.installation -# RUN: %t.venv/bin/lnt create %t.installation diff --git a/tests/utils/installation-server.shtest b/tests/utils/installation-server.shtest deleted file mode 100644 index dbac3ed3..00000000 --- a/tests/utils/installation-server.shtest +++ /dev/null @@ -1,8 +0,0 @@ -# Check that installation using the server requirements works properly. -# -# RUN: rm -rf %t.venv -# RUN: python -m venv %t.venv -# RUN: cd %{src_root} -# RUN: %t.venv/bin/python -m pip install -r requirements.server.txt -# RUN: rm -rf %t.installation -# RUN: %t.venv/bin/lnt create %t.installation diff --git a/tests/utils/installation.shtest b/tests/utils/installation.shtest new file mode 100644 index 00000000..ecb9b963 --- /dev/null +++ b/tests/utils/installation.shtest @@ -0,0 +1,17 @@ +# Check that installation using the client requirements works properly. +# +# RUN: rm -rf %t.venv +# RUN: python -m venv %t.venv +# RUN: cd %{src_root} +# RUN: %t.venv/bin/python -m pip install -r requirements.client.txt +# RUN: rm -rf %t.installation +# RUN: %t.venv/bin/lnt create %t.installation + +# Check that installation using the server requirements works properly. +# +# RUN: rm -rf %t.venv +# RUN: python -m venv %t.venv +# RUN: cd %{src_root} +# RUN: %t.venv/bin/python -m pip install -r requirements.server.txt +# RUN: rm -rf %t.installation +# RUN: %t.venv/bin/lnt create %t.installation