PR for llvm/llvm-project#61388#406
Merged
tstellar merged 1 commit intorelease/16.xfrom Apr 4, 2023
Merged
Conversation
…ersions of known extensions This Moves ELFObjectFile to using RISCVISAInfo::parseNormalizedArchString which does not ignore or produce an error for ISA extensions with a version that isn't recognised/supported by LLVM. As current GCC is marking its objects with a higher version of the A, F, and D extensions than LLVM (see [extension versioning discussion](https://discourse.llvm.org/t/rfc-resolving-issues-related-to-extension-versioning-in-risc-v/68472) this massively improves the usability of llvm-objdump with such binaries. This patch is functionally a cherry-pick of af602ed and 91c6174, though I've constructed the backport manually because other changes unrelated to this specific fix make a direct cherry pick difficult.
Contributor
|
This is the objdump equivalent of llvm/llvm-project#60889. I've done the cherry-pick manually as the additional testing for other RISCVISAInfo functions (and related fixes) make it difficult to directly cherry-pick. Without this fix, llvm-objdump is going to refuse to process RISC-V objects from a recent GCC (or from a newer LLVM once D147179 lands). This is a regression since LLVM 15, and the fix ends up being small and non-invasive. |
Contributor
|
Can someone please advise what to do about the failing "abi-compare" test? I can't see how this change could have triggered it, and also can't see how to view the build artifact. Thanks in advance. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves llvm/llvm-project#61388