From 0ef61ed54dca2e974928c55b2144b57d4c4ff621 Mon Sep 17 00:00:00 2001 From: Luke Lau Date: Mon, 11 Mar 2024 18:00:29 +0800 Subject: [PATCH] [RISCV] Move NodeExtensionHelper assert to getOrCreateExtendedOp. NFC Move the narrow types assert from the ZERO_EXTEND/SIGN_EXTEND case in fillUpExtensionSupport to getOrCreateExtendedOp so we check the other nodes too. --- llvm/lib/Target/RISCV/RISCVISelLowering.cpp | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp index 71759fdde9af0..08678a859ae2b 100644 --- a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp +++ b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp @@ -13490,6 +13490,7 @@ struct NodeExtensionHelper { MVT NarrowVT = getNarrowType(Root, *SupportsExt); SDValue Source = getSource(); + assert(Subtarget.getTargetLowering()->isTypeLegal(Source.getValueType())); if (Source.getValueType() == NarrowVT) return Source; @@ -13657,9 +13658,6 @@ struct NodeExtensionHelper { unsigned ScalarBits = VT.getScalarSizeInBits(); unsigned NarrowScalarBits = NarrowVT.getScalarSizeInBits(); - assert( - Subtarget.getTargetLowering()->isTypeLegal(NarrowElt.getValueType())); - // Ensure the extension's semantic is equivalent to rvv vzext or vsext. if (ScalarBits != NarrowScalarBits * 2) break;