diff --git a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp index 5d301b815d38e..54632f5662b63 100644 --- a/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp +++ b/clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp @@ -1005,6 +1005,7 @@ StructValue &refreshStructValue(const Expr &Expr, Environment &Env) { StorageLocation *Loc = Env.getStorageLocationStrict(Expr); if (Loc == nullptr) { Loc = &Env.createStorageLocation(Expr); + Env.setStorageLocation(Expr, *Loc); } Env.setValue(*Loc, NewVal); } diff --git a/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp b/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp index e9531d1e7e8fd..ba316f7d35e89 100644 --- a/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp +++ b/clang/unittests/Analysis/FlowSensitive/DataflowEnvironmentTest.cpp @@ -25,6 +25,7 @@ namespace { using namespace clang; using namespace dataflow; using ::clang::dataflow::test::getFieldValue; +using ::testing::IsNull; using ::testing::NotNull; class EnvironmentTest : public ::testing::Test { @@ -252,4 +253,35 @@ TEST_F(EnvironmentTest, InitGlobalVarsConstructor) { EXPECT_THAT(Env.getValue(*Var), NotNull()); } +TEST_F(EnvironmentTest, RefreshStructValue) { + using namespace ast_matchers; + + std::string Code = R"cc( + struct S {}; + void target () { + S s; + s; + } + )cc"; + + auto Unit = + tooling::buildASTFromCodeWithArgs(Code, {"-fsyntax-only", "-std=c++11"}); + auto &Context = Unit->getASTContext(); + + ASSERT_EQ(Context.getDiagnostics().getClient()->getNumErrors(), 0U); + + auto Results = match(functionDecl(hasName("target")).bind("target"), Context); + const auto *Target = selectFirst("target", Results); + ASSERT_THAT(Target, NotNull()); + + Results = match(declRefExpr(to(varDecl(hasName("s")))).bind("s"), Context); + const auto *DRE = selectFirst("s", Results); + ASSERT_THAT(DRE, NotNull()); + + Environment Env(DAContext, *Target); + EXPECT_THAT(Env.getStorageLocationStrict(*DRE), IsNull()); + refreshStructValue(*DRE, Env); + EXPECT_THAT(Env.getStorageLocationStrict(*DRE), NotNull()); +} + } // namespace