Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[lldb] Remove orphaned modules in a loop
Summary: When modules reference each other (which happens for example with the different modules LLDB loads when debugging -gmodules-compiled binaries), just iterating over the module list once isn't good enough to find all orphans. Any removed modules in the module list will also clear up the shared pointers they hold to other modules, so after any module was removed from the list, LLDB should iterate again and check if any additional modules can no be safely deleted. This is currently causing that many gmodules tests are not cleaning up all allocated modules which causes cleanup asserts to fail (right now these asserts just mark the test as unsupported, but after D83865 the tests will start failing). Reviewers: aprantl, clayborg, JDevlieghere Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D84015
- Loading branch information