diff --git a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp index fc392fec36865..8cfda506fc254 100644 --- a/clang-tools-extra/include-cleaner/lib/WalkAST.cpp +++ b/clang-tools-extra/include-cleaner/lib/WalkAST.cpp @@ -214,6 +214,10 @@ class ASTWalker : public RecursiveASTVisitor { return true; } bool VisitVarDecl(VarDecl *VD) { + // Ignore the parameter decl itself (its children were handled elsewhere), + // as they don't contribute to the main-file #include. + if (llvm::isa(VD)) + return true; // Mark declaration from definition as it needs type-checking. if (VD->isThisDeclarationADefinition()) report(VD->getLocation(), VD); diff --git a/clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp b/clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp index bad55e1433549..5b5f77b5fdea8 100644 --- a/clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp +++ b/clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp @@ -91,7 +91,8 @@ TEST_F(WalkUsedTest, Basic) { #include "header.h" #include "private.h" - void $bar^bar($private^Private $p^p) { + // No reference reported for the Parameter "p". + void $bar^bar($private^Private p) { $foo^foo(); std::$vector^vector $vconstructor^$v^v; $builtin^__builtin_popcount(1); @@ -120,7 +121,6 @@ TEST_F(WalkUsedTest, Basic) { offsetToProviders(AST, SM), UnorderedElementsAre( Pair(Code.point("bar"), UnorderedElementsAre(MainFile)), - Pair(Code.point("p"), UnorderedElementsAre(MainFile)), Pair(Code.point("private"), UnorderedElementsAre(PublicFile, PrivateFile)), Pair(Code.point("foo"), UnorderedElementsAre(HeaderFile)),