Skip to content
Permalink
Browse files

Merging r369310:

------------------------------------------------------------------------
r369310 | hubert.reinterpretcast | 2019-08-20 01:12:48 +0200 (Tue, 20 Aug 2019) | 24 lines

[cmake] Link in LLVMPasses due to dependency by LLVMOrcJIT; NFC

Summary:
rL367756 (f5c40cb) increases the dependency of LLVMOrcJIT on LLVMPasses.
In particular, symbols defined in LLVMPasses that are referenced by the
destructor of `PassBuilder` are now referenced by LLVMOrcJIT through
`Speculation.cpp.o`.

We believe that referencing symbols defined in LLVMPasses in the
destructor of `PassBuilder` is valid, and that adding to the set of such
symbols is legitimate. To support such cases, this patch adds LLVMPasses
to the set of libraries being linked when linking in LLVMOrcJIT causes
such symbols from LLVMPasses to be referenced.

Reviewers: Whitney, anhtuyen, pree-jackie

Reviewed By: pree-jackie

Subscribers: mgorny, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D66441

------------------------------------------------------------------------

llvm-svn: 371042
  • Loading branch information...
zmodem committed Sep 5, 2019
1 parent 8b1a3a3 commit 1b8425cf6f834c14645231d3c2f58fc441f2b524
@@ -33,4 +33,5 @@ target_link_libraries(LLVMOrcJIT
PRIVATE
LLVMBitReader
LLVMBitWriter
LLVMPasses
)
@@ -12,6 +12,7 @@ set(LLVM_LINK_COMPONENTS
MCJIT
Object
OrcJIT
Passes
RuntimeDyld
SelectionDAG
Support
@@ -4,6 +4,7 @@ set(LLVM_LINK_COMPONENTS
ExecutionEngine
Object
OrcJIT
Passes
RuntimeDyld
Support
native

0 comments on commit 1b8425c

Please sign in to comment.
You can’t perform that action at this time.