Skip to content

Commit

Permalink
[clang][Interp] Fix a crash when calling invalid constexpr functions
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D147845
  • Loading branch information
tbaederr committed Apr 8, 2023
1 parent 2c1d795 commit 1c818b0
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 1 deletion.
3 changes: 2 additions & 1 deletion clang/lib/AST/Interp/InterpFrame.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,8 @@ void print(llvm::raw_ostream &OS, const Pointer &P, ASTContext &Ctx,
}

// Drop the first pointer since we print it unconditionally anyway.
Levels.erase(Levels.begin());
if (!Levels.empty())
Levels.erase(Levels.begin());

printDesc(P.getDeclDesc());
for (const auto &It : Levels) {
Expand Down
17 changes: 17 additions & 0 deletions clang/test/AST/Interp/functions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -202,3 +202,20 @@ constexpr int nyd(int m);
constexpr int doit() { return nyd(10); }
constexpr int nyd(int m) { return m; }
static_assert(doit() == 10, "");

namespace InvalidCall {
struct S {
constexpr int a() const { // expected-error {{never produces a constant expression}} \
// ref-error {{never produces a constant expression}}
return 1 / 0; // expected-note 2{{division by zero}} \
// expected-warning {{is undefined}} \
// ref-note 2{{division by zero}} \
// ref-warning {{is undefined}}
}
};
constexpr S s;
static_assert(s.a() == 1); // expected-error {{not an integral constant expression}} \
// expected-note {{in call to}} \
// ref-error {{not an integral constant expression}} \
// ref-note {{in call to}}
}

0 comments on commit 1c818b0

Please sign in to comment.